Re: [PATCH 3/5] uprobes: remove check for uprobe variable in handle_swbp()

2012-08-09 Thread Suzuki K. Poulose
On 08/08/2012 03:05 PM, Sebastian Andrzej Siewior wrote: On 08/08/2012 11:10 AM, Suzuki K. Poulose wrote: --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1528,17 +1528,15 @@ cleanup_ret: utask->active_uprobe = NULL; utask->state = UTASK_RUNNING; } - if (uprobe) { - if (!(uprobe->

Re: [PATCH 3/5] uprobes: remove check for uprobe variable in handle_swbp()

2012-08-08 Thread Oleg Nesterov
On 08/07, Sebastian Andrzej Siewior wrote: > > by the time we get here (after we pass cleanup_ret) uprobe is always is > set. If it is NULL we leave very early in the code. Reviewed-by: Oleg Nesterov > Signed-off-by: Sebastian Andrzej Siewior > --- > kernel/events/uprobes.c | 16 +++-

Re: [PATCH 3/5] uprobes: remove check for uprobe variable in handle_swbp()

2012-08-08 Thread Sebastian Andrzej Siewior
On 08/08/2012 11:10 AM, Suzuki K. Poulose wrote: --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1528,17 +1528,15 @@ cleanup_ret: utask->active_uprobe = NULL; utask->state = UTASK_RUNNING; } - if (uprobe) { - if (!(uprobe->flags & UPROBE_SKIP_SSTEP)) + if (!(uprobe->flags & UPROBE

Re: [PATCH 3/5] uprobes: remove check for uprobe variable in handle_swbp()

2012-08-08 Thread Suzuki K. Poulose
On 08/07/2012 09:42 PM, Sebastian Andrzej Siewior wrote: by the time we get here (after we pass cleanup_ret) uprobe is always is set. If it is NULL we leave very early in the code. Signed-off-by: Sebastian Andrzej Siewior --- kernel/events/uprobes.c | 16 +++- 1 file changed, 7

[PATCH 3/5] uprobes: remove check for uprobe variable in handle_swbp()

2012-08-07 Thread Sebastian Andrzej Siewior
by the time we get here (after we pass cleanup_ret) uprobe is always is set. If it is NULL we leave very early in the code. Signed-off-by: Sebastian Andrzej Siewior --- kernel/events/uprobes.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/kernel/events/up