Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-23 Thread Linus Walleij
On Tue, Jul 22, 2014 at 9:17 AM, Alexandre Courbot wrote: > As GPIO descriptors are not going to remain unique anymore, having this > function public is not safe. Restrain its use to gpiolib since we have > no user outside of it. > > Signed-off-by: Alexandre Courbot Patch applied. Yours, Linus

Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-23 Thread Alexandre Courbot
On Wed, Jul 23, 2014 at 3:21 PM, Guenter Roeck wrote: > On 07/22/2014 10:39 PM, Alexandre Courbot wrote: >> >> On Wed, Jul 23, 2014 at 12:47 PM, Guenter Roeck >> wrote: >>> >>> On 07/22/2014 08:10 PM, Alexandre Courbot wrote: On Wed, Jul 23, 2014 at 5:17 AM, Guenter Roeck wro

Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-22 Thread Guenter Roeck
On 07/22/2014 10:39 PM, Alexandre Courbot wrote: On Wed, Jul 23, 2014 at 12:47 PM, Guenter Roeck wrote: On 07/22/2014 08:10 PM, Alexandre Courbot wrote: On Wed, Jul 23, 2014 at 5:17 AM, Guenter Roeck wrote: On Tue, Jul 22, 2014 at 04:17:41PM +0900, Alexandre Courbot wrote: As GPIO descri

Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-22 Thread Alexandre Courbot
On Wed, Jul 23, 2014 at 12:47 PM, Guenter Roeck wrote: > On 07/22/2014 08:10 PM, Alexandre Courbot wrote: >> >> On Wed, Jul 23, 2014 at 5:17 AM, Guenter Roeck wrote: >>> >>> On Tue, Jul 22, 2014 at 04:17:41PM +0900, Alexandre Courbot wrote: As GPIO descriptors are not going to remain un

Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-22 Thread Guenter Roeck
On 07/22/2014 08:10 PM, Alexandre Courbot wrote: On Wed, Jul 23, 2014 at 5:17 AM, Guenter Roeck wrote: On Tue, Jul 22, 2014 at 04:17:41PM +0900, Alexandre Courbot wrote: As GPIO descriptors are not going to remain unique anymore, having this function public is not safe. Restrain its use to gpi

Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-22 Thread Alexandre Courbot
On Wed, Jul 23, 2014 at 5:17 AM, Guenter Roeck wrote: > On Tue, Jul 22, 2014 at 04:17:41PM +0900, Alexandre Courbot wrote: >> As GPIO descriptors are not going to remain unique anymore, having this >> function public is not safe. Restrain its use to gpiolib since we have >> no user outside of it.

Re: [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-22 Thread Guenter Roeck
On Tue, Jul 22, 2014 at 04:17:41PM +0900, Alexandre Courbot wrote: > As GPIO descriptors are not going to remain unique anymore, having this > function public is not safe. Restrain its use to gpiolib since we have > no user outside of it. > If I implement a gpio chip driver built as module, and I

[PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private

2014-07-22 Thread Alexandre Courbot
As GPIO descriptors are not going to remain unique anymore, having this function public is not safe. Restrain its use to gpiolib since we have no user outside of it. Signed-off-by: Alexandre Courbot --- drivers/gpio/gpiolib-of.c | 2 +- drivers/gpio/gpiolib.c | 1 - drivers/gpio/gpiolib.h