Re: [PATCH 3/5] drivers/atm/atmtcp.c: fix error return code

2014-08-07 Thread David Miller
From: Julia Lawall Date: Thu, 7 Aug 2014 15:31:05 +0200 (CEST) > From: Julia Lawall > > Convert a zero return value on error to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.li

Re: [PATCH 3/5] drivers/atm/atmtcp.c: fix error return code

2014-08-07 Thread chas williams - CONTRACTOR
On Thu, 7 Aug 2014 15:31:05 +0200 (CEST) Julia Lawall wrote: > diff --git a/drivers/atm/atmtcp.c b/drivers/atm/atmtcp.c > index 0e3f8f9..c8e4fb4 100644 > --- a/drivers/atm/atmtcp.c > +++ b/drivers/atm/atmtcp.c > @@ -299,6 +299,7 @@ static int atmtcp_c_send(struct atm_vcc *vcc,struct > sk_buff *

Re: [PATCH 3/5] drivers/atm/atmtcp.c: fix error return code

2014-08-07 Thread Julia Lawall
From: Julia Lawall Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\

Re: [PATCH 3/5] drivers/atm/atmtcp.c: fix error return code

2014-08-07 Thread Julia Lawall
On Thu, 7 Aug 2014, chas williams - CONTRACTOR wrote: > On Thu, 7 Aug 2014 14:49:06 +0200 > Julia Lawall wrote: > > > From: Julia Lawall > > > > Convert a zero return value on error to a negative one, as returned > > elsewhere in the function. > > > > A simplified version of the semantic match

Re: [PATCH 3/5] drivers/atm/atmtcp.c: fix error return code

2014-08-07 Thread chas williams - CONTRACTOR
On Thu, 7 Aug 2014 14:49:06 +0200 Julia Lawall wrote: > From: Julia Lawall > > Convert a zero return value on error to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/)

[PATCH 3/5] drivers/atm/atmtcp.c: fix error return code

2014-08-07 Thread Julia Lawall
From: Julia Lawall Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\