Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-06-27 Thread Stefano Garzarella
On Thu, Jun 13, 2019 at 04:57:15PM +0800, Jason Wang wrote: > > On 2019/6/6 下午4:11, Stefano Garzarella wrote: > > On Fri, May 31, 2019 at 05:56:39PM +0800, Jason Wang wrote: > > > On 2019/5/31 下午4:18, Stefano Garzarella wrote: > > > > On Thu, May 30, 2019 at 07:59:14PM +0800, Jason Wang wrote: > >

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-06-13 Thread Jason Wang
On 2019/6/6 下午4:11, Stefano Garzarella wrote: On Fri, May 31, 2019 at 05:56:39PM +0800, Jason Wang wrote: On 2019/5/31 下午4:18, Stefano Garzarella wrote: On Thu, May 30, 2019 at 07:59:14PM +0800, Jason Wang wrote: On 2019/5/30 下午6:10, Stefano Garzarella wrote: On Thu, May 30, 2019 at 05:46:1

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-06-06 Thread Stefano Garzarella
On Fri, May 31, 2019 at 05:56:39PM +0800, Jason Wang wrote: > On 2019/5/31 下午4:18, Stefano Garzarella wrote: > > On Thu, May 30, 2019 at 07:59:14PM +0800, Jason Wang wrote: > > > On 2019/5/30 下午6:10, Stefano Garzarella wrote: > > > > On Thu, May 30, 2019 at 05:46:18PM +0800, Jason Wang wrote: > > >

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-31 Thread Jason Wang
On 2019/5/31 下午4:18, Stefano Garzarella wrote: On Thu, May 30, 2019 at 07:59:14PM +0800, Jason Wang wrote: On 2019/5/30 下午6:10, Stefano Garzarella wrote: On Thu, May 30, 2019 at 05:46:18PM +0800, Jason Wang wrote: On 2019/5/29 下午6:58, Stefano Garzarella wrote: On Wed, May 29, 2019 at 11:22:

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-31 Thread Stefano Garzarella
On Thu, May 30, 2019 at 07:59:14PM +0800, Jason Wang wrote: > > On 2019/5/30 下午6:10, Stefano Garzarella wrote: > > On Thu, May 30, 2019 at 05:46:18PM +0800, Jason Wang wrote: > > > On 2019/5/29 下午6:58, Stefano Garzarella wrote: > > > > On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: >

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-30 Thread Jason Wang
On 2019/5/30 下午6:10, Stefano Garzarella wrote: On Thu, May 30, 2019 at 05:46:18PM +0800, Jason Wang wrote: On 2019/5/29 下午6:58, Stefano Garzarella wrote: On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: On 2019/5/28 下午6:56, Stefano Garzarella wrote: We flush all pending works bef

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-30 Thread Stefano Garzarella
On Thu, May 30, 2019 at 05:46:18PM +0800, Jason Wang wrote: > > On 2019/5/29 下午6:58, Stefano Garzarella wrote: > > On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: > > > On 2019/5/28 下午6:56, Stefano Garzarella wrote: > > > > We flush all pending works before to call vdev->config->reset(

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-30 Thread Jason Wang
On 2019/5/29 下午6:58, Stefano Garzarella wrote: On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: On 2019/5/28 下午6:56, Stefano Garzarella wrote: We flush all pending works before to call vdev->config->reset(vdev), but other works can be queued before the vdev->config->del_vqs(vdev),

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-29 Thread Stefano Garzarella
On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: > > On 2019/5/28 下午6:56, Stefano Garzarella wrote: > > We flush all pending works before to call vdev->config->reset(vdev), > > but other works can be queued before the vdev->config->del_vqs(vdev), > > so we add another flush after it, to

Re: [PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-28 Thread Jason Wang
On 2019/5/28 下午6:56, Stefano Garzarella wrote: We flush all pending works before to call vdev->config->reset(vdev), but other works can be queued before the vdev->config->del_vqs(vdev), so we add another flush after it, to avoid use after free. Suggested-by: Michael S. Tsirkin Signed-off-by:

[PATCH 3/4] vsock/virtio: fix flush of works during the .remove()

2019-05-28 Thread Stefano Garzarella
We flush all pending works before to call vdev->config->reset(vdev), but other works can be queued before the vdev->config->del_vqs(vdev), so we add another flush after it, to avoid use after free. Suggested-by: Michael S. Tsirkin Signed-off-by: Stefano Garzarella --- net/vmw_vsock/virtio_trans