Re: [PATCH 3/4] tty: Lock tty pair in tty_init_dev()

2018-08-31 Thread Dmitry Safonov
On Fri, 2018-08-31 at 08:54 +0200, Jiri Slaby wrote: > On 08/29/2018, 06:28 PM, Dmitry Safonov wrote: > > On Wed, 2018-08-29 at 16:46 +0200, Jiri Slaby wrote: > > > On 08/29/2018, 04:23 AM, Dmitry Safonov wrote: > > > > It's safe to not lock both here - done to silence attempt > > > > lockdep > > >

Re: [PATCH 3/4] tty: Lock tty pair in tty_init_dev()

2018-08-30 Thread Jiri Slaby
On 08/29/2018, 06:28 PM, Dmitry Safonov wrote: > On Wed, 2018-08-29 at 16:46 +0200, Jiri Slaby wrote: >> On 08/29/2018, 04:23 AM, Dmitry Safonov wrote: >>> It's safe to not lock both here - done to silence attempt lockdep >>> assert in >>> tty_ldisc_open(), which will be added with following patch.

Re: [PATCH 3/4] tty: Lock tty pair in tty_init_dev()

2018-08-29 Thread Dmitry Safonov
On Wed, 2018-08-29 at 16:46 +0200, Jiri Slaby wrote: > On 08/29/2018, 04:23 AM, Dmitry Safonov wrote: > > It's safe to not lock both here - done to silence attempt lockdep > > assert in > > tty_ldisc_open(), which will be added with following patch. > > SOrry, could you elaborate here? I don't fol

Re: [PATCH 3/4] tty: Lock tty pair in tty_init_dev()

2018-08-29 Thread Jiri Slaby
On 08/29/2018, 04:23 AM, Dmitry Safonov wrote: > It's safe to not lock both here - done to silence attempt lockdep assert in > tty_ldisc_open(), which will be added with following patch. SOrry, could you elaborate here? I don't follow... thanks, -- js suse labs

[PATCH 3/4] tty: Lock tty pair in tty_init_dev()

2018-08-28 Thread Dmitry Safonov
It's safe to not lock both here - done to silence attempt lockdep assert in tty_ldisc_open(), which will be added with following patch. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Signed-off-by: Dmitry Safonov --- drivers/tty/tty_io.c| 5 ++--- drivers/tty/tty_ldisc.c | 6 ++ include/linux/t