Re: [PATCH 3/4] tty/serial: at91: prevent null dereference in tasklet function

2014-01-07 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Jan 07, 2014 at 08:52:34PM -0500, Mark Roszko wrote: > This patch I was somewhat hesitant to pushing to Atmel when I did the other > two > patches. Then why did you? :) > The main issue is

Re: [PATCH 3/4] tty/serial: at91: prevent null dereference in tasklet function

2014-01-07 Thread Greg KH
On Tue, Jan 07, 2014 at 11:45:08AM +0100, Nicolas Ferre wrote: > From: Marek Roszko > > Something asks a tasklet to be scheduled when the uart port is closed. What is that something? Shouldn't you track that down and find the real problem here? > Need to supress the kernel panic for now by che

[PATCH 3/4] tty/serial: at91: prevent null dereference in tasklet function

2014-01-07 Thread Nicolas Ferre
From: Marek Roszko Something asks a tasklet to be scheduled when the uart port is closed. Need to supress the kernel panic for now by checking if the port is NULL or not. Signed-off-by: Marek Roszko Acked-by: Leilei Zhao Cc: # v3.12 Signed-off-by: Nicolas Ferre --- drivers/tty/serial/atmel_