Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

2015-08-12 Thread Joonyoung Shim
On 08/12/2015 09:10 AM, Krzysztof Kozlowski wrote: > On 11.08.2015 20:28, Joonyoung Shim wrote: >> The driver uses clk_prepare_enable()/clk_disable_unprepare() only in >> probe only, elsewhere, use the unified functions for enable/disable of >> clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk()

Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

2015-08-11 Thread Krzysztof Kozlowski
On 11.08.2015 20:28, Joonyoung Shim wrote: > The driver uses clk_prepare_enable()/clk_disable_unprepare() only in > probe only, elsewhere, use the unified functions for enable/disable of > clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so it's better > to use them for consistency of code.

[PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

2015-08-11 Thread Joonyoung Shim
The driver uses clk_prepare_enable()/clk_disable_unprepare() only in probe only, elsewhere, use the unified functions for enable/disable of clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so it's better to use them for consistency of code. Signed-off-by: Joonyoung Shim --- drivers/rtc/rt