Re: [PATCH 3/4] regulator: Add labibb driver

2019-06-18 Thread Mark Brown
On Tue, Jun 18, 2019 at 11:51:18AM +0530, Nisha Kumari wrote: > On 6/13/2019 10:55 PM, Mark Brown wrote: > > > + labibb->lab_vreg.vreg_enabled = 1; > > What function does this serve? It never seems to be read. > Its used in next patch for handling interrupts It'd be better to move this code into

Re: [PATCH 3/4] regulator: Add labibb driver

2019-06-17 Thread Nisha Kumari
On 6/13/2019 10:55 PM, Mark Brown wrote: On Wed, Jun 12, 2019 at 04:30:51PM +0530, Nisha Kumari wrote: +static int qcom_labibb_read(struct qcom_labibb *labibb, u16 address, + u8 *val, int count) +{ + int ret; + + ret = regmap_bulk_read(labibb->regmap, add

Re: [PATCH 3/4] regulator: Add labibb driver

2019-06-17 Thread Nisha Kumari
On 6/13/2019 10:34 PM, Bjorn Andersson wrote: On Wed 12 Jun 04:00 PDT 2019, Nisha Kumari wrote: This patch adds labibb regulator driver for supporting LCD mode display on SDM845 platform. Signed-off-by: Nisha Kumari --- drivers/regulator/Kconfig | 10 + drivers/regulator

Re: [PATCH 3/4] regulator: Add labibb driver

2019-06-13 Thread Mark Brown
On Wed, Jun 12, 2019 at 04:30:51PM +0530, Nisha Kumari wrote: > +static int qcom_labibb_read(struct qcom_labibb *labibb, u16 address, > + u8 *val, int count) > +{ > + int ret; > + > + ret = regmap_bulk_read(labibb->regmap, address, val, count); > + if (ret < 0)

Re: [PATCH 3/4] regulator: Add labibb driver

2019-06-13 Thread Bjorn Andersson
On Wed 12 Jun 04:00 PDT 2019, Nisha Kumari wrote: > This patch adds labibb regulator driver for supporting LCD mode display > on SDM845 platform. > > Signed-off-by: Nisha Kumari > --- > drivers/regulator/Kconfig | 10 + > drivers/regulator/Makefile| 1 + > dri

[PATCH 3/4] regulator: Add labibb driver

2019-06-12 Thread Nisha Kumari
This patch adds labibb regulator driver for supporting LCD mode display on SDM845 platform. Signed-off-by: Nisha Kumari --- drivers/regulator/Kconfig | 10 + drivers/regulator/Makefile| 1 + drivers/regulator/qcom-labibb-regulator.c | 438 ++