Re: [PATCH 3/4] perf tools: Add initialized arg into unwind__prepare_access

2016-07-04 Thread Jiri Olsa
On Mon, Jul 04, 2016 at 04:25:11PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > } > > @@ -67,7 +69,8 @@ unwind__get_entries(unwind_entry_cb_t cb __maybe_unused, > > } > > > > static inline int unwind__prepare_access(struct thread *thread > > __maybe_unused, > > -

Re: [PATCH 3/4] perf tools: Add initialized arg into unwind__prepare_access

2016-07-04 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 04, 2016 at 02:16:22PM +0200, Jiri Olsa escreveu: > Adding initialized arg into unwind__prepare_access > to get feedback about the initialization state. > > It's not possible to get it from error code, because > we return 0 even in case we don't recognize dso, which > is valid. > > Th

[PATCH 3/4] perf tools: Add initialized arg into unwind__prepare_access

2016-07-04 Thread Jiri Olsa
Adding initialized arg into unwind__prepare_access to get feedback about the initialization state. It's not possible to get it from error code, because we return 0 even in case we don't recognize dso, which is valid. The 'initialized' value is used in following patch to speedup unwind__prepare_ac