Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

2015-09-09 Thread Joe Perches
On Wed, 2015-09-09 at 11:45 -0700, Joe Perches wrote: > On Wed, 2015-09-09 at 20:34 +0200, Rasmus Villemoes wrote: > > mc_spec and mc_other are u32*, we allocate 0x200 = 512 bytes = 128 > > u32s, and pointer arithmetic makes mc_other point to the latter 64. Then > > the memory is cleared 256 bytes

Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

2015-09-09 Thread Joe Perches
On Wed, 2015-09-09 at 20:34 +0200, Rasmus Villemoes wrote: > mc_spec and mc_other are u32*, we allocate 0x200 = 512 bytes = 128 > u32s, and pointer arithmetic makes mc_other point to the latter 64. Then > the memory is cleared 256 bytes at a time. > > It's unusual and slightly obfuscated code, but

Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

2015-09-09 Thread Rasmus Villemoes
On Wed, Sep 09 2015, Joe Perches wrote: > On Wed, 2015-09-09 at 10:38 +0200, Rasmus Villemoes wrote: >> The double memset is a little ugly; using kzalloc avoids it altogether. > [] >> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c >> b/drivers/net/ethernet/marvell/mv643xx_eth.c > [] >>

Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

2015-09-09 Thread Joe Perches
On Wed, 2015-09-09 at 10:38 +0200, Rasmus Villemoes wrote: > The double memset is a little ugly; using kzalloc avoids it altogether. [] > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c > b/drivers/net/ethernet/marvell/mv643xx_eth.c [] > @@ -1859,14 +1859,11 @@ oom: > return;

[PATCH 3/4] net: mv643xx_eth: use kzalloc

2015-09-09 Thread Rasmus Villemoes
The double memset is a little ugly; using kzalloc avoids it altogether. Signed-off-by: Rasmus Villemoes --- drivers/net/ethernet/marvell/mv643xx_eth.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvel