Re: [PATCH 3/4] KVM: i8254: remove unnecessary irqchip_in_kernel check

2015-07-30 Thread Paolo Bonzini
On 30/07/2015 06:36, Steve Rutherford wrote: > On Wed, Jul 29, 2015 at 03:28:57PM +0200, Paolo Bonzini wrote: >> > The PIT is only created if irqchip_in_kernel returns true, so the >> > check is superfluous. > I poked around. Looks to me like the existence of an IOAPIC is not > checked on the cre

Re: [PATCH 3/4] KVM: i8254: remove unnecessary irqchip_in_kernel check

2015-07-29 Thread Steve Rutherford
On Wed, Jul 29, 2015 at 03:28:57PM +0200, Paolo Bonzini wrote: > The PIT is only created if irqchip_in_kernel returns true, so the > check is superfluous. I poked around. Looks to me like the existence of an IOAPIC is not checked on the creation of the in-kernel PIT. Userspace might limit itself to

[PATCH 3/4] KVM: i8254: remove unnecessary irqchip_in_kernel check

2015-07-29 Thread Paolo Bonzini
The PIT is only created if irqchip_in_kernel returns true, so the check is superfluous. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/i8254.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c index f90952f64e79..f588eb7bdf45 100644 --