Re: [PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-10 Thread Tony Lindgren
* Dmitry Torokhov [210110 06:34]: > Hi Tony, > > On Wed, Jan 06, 2021 at 02:58:21PM +0200, Tony Lindgren wrote: > > @@ -301,6 +348,7 @@ static int omap4_keypad_probe(struct platform_device > > *pdev) > > } > > > > keypad_data->irq = irq; > > + mutex_init(&keypad_data->lock); > > >

Re: [PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-09 Thread Dmitry Torokhov
Hi Tony, On Wed, Jan 06, 2021 at 02:58:21PM +0200, Tony Lindgren wrote: > @@ -301,6 +348,7 @@ static int omap4_keypad_probe(struct platform_device > *pdev) > } > > keypad_data->irq = irq; > + mutex_init(&keypad_data->lock); > > error = omap4_keypad_parse_dt(&pdev->dev, k

Re: [PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-06 Thread kernel test robot
Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on linus/master v5.11-rc2 next-20210104] [cannot apply to hid/for-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

Re: [PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-06 Thread kernel test robot
Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on linus/master v5.11-rc2 next-20210104] [cannot apply to hid/for-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

Re: [PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-06 Thread kernel test robot
Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on linus/master v5.11-rc2 next-20210104] [cannot apply to hid/for-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

[PATCH 3/4] Input: omap4-keypad - use PM runtime to check keys for errata

2021-01-06 Thread Tony Lindgren
We are still missing handling for errata i689 related issues for the case where we never see a key up interrupt for the last pressed key. To fix the issue, we must scan the key state again after the keyboard controller has idled to check if a key up event was missed. This is described in the omap4