Re: [PATCH 3/4] [SMB3] Fix dereference before null check warning

2015-04-01 Thread Jeff Layton
On Wed, 1 Apr 2015 00:00:57 -0500 Steve French wrote: > On Tue, Mar 31, 2015 at 7:46 PM, Jeff Layton wrote: > > On Fri, 27 Mar 2015 00:28:01 -0500 > > Steve French wrote: > > > >> null tcon is not likely in these paths in current > >> code, but obviously it does clarify the code to > >> check f

Re: [PATCH 3/4] [SMB3] Fix dereference before null check warning

2015-03-31 Thread Steve French
On Tue, Mar 31, 2015 at 7:46 PM, Jeff Layton wrote: > On Fri, 27 Mar 2015 00:28:01 -0500 > Steve French wrote: > >> null tcon is not likely in these paths in current >> code, but obviously it does clarify the code to >> check for null (if at all) before derefrencing >> rather than after. >> >> Re

Re: [PATCH 3/4] [SMB3] Fix dereference before null check warning

2015-03-31 Thread Jeff Layton
On Fri, 27 Mar 2015 00:28:01 -0500 Steve French wrote: > null tcon is not likely in these paths in current > code, but obviously it does clarify the code to > check for null (if at all) before derefrencing > rather than after. > > Reported by Coverity (CID 1042666) > > Signed-off-by: Steve Fren

Re: [PATCH 3/4] [SMB3] Fix dereference before null check warning

2015-03-30 Thread Sachin Prabhu
On Fri, 2015-03-27 at 00:28 -0500, Steve French wrote: > null tcon is not likely in these paths in current > code, but obviously it does clarify the code to > check for null (if at all) before derefrencing > rather than after. > > Reported by Coverity (CID 1042666) > > Signed-off-by: Steve French

Re: [PATCH 3/4] [SMB3] Fix dereference before null check warning

2015-03-28 Thread Shirish Pargaonkar
Looks correct. Acked-by: Shirish Pargaonkar On Fri, Mar 27, 2015 at 12:28 AM, Steve French wrote: > null tcon is not likely in these paths in current > code, but obviously it does clarify the code to > check for null (if at all) before derefrencing > rather than after. > > Reported by Coverity

[PATCH 3/4] [SMB3] Fix dereference before null check warning

2015-03-26 Thread Steve French
null tcon is not likely in these paths in current code, but obviously it does clarify the code to check for null (if at all) before derefrencing rather than after. Reported by Coverity (CID 1042666) Signed-off-by: Steve French --- fs/cifs/smb2pdu.c | 13 - 1 file changed, 8 insertio