RE: [PATCH 3/3] watchdog: ds1374_wdt: Introduce Dallas/Maxim DS1374 Watchdog driver

2020-06-24 Thread 陳昭勳
Hi, > On 6/22/20 11:28 PM, Johnson CH Chen (陳昭勳) wrote: > > Hi, > > > > Thanks for your good detailed suggestions! > > > > Other feedback suggests to convert the driver to use the watchdog core in the > rtc code. I would suggest to follow that suggestion. > Understand the following suggestions f

Re: [PATCH 3/3] watchdog: ds1374_wdt: Introduce Dallas/Maxim DS1374 Watchdog driver

2020-06-23 Thread Guenter Roeck
On 6/22/20 11:28 PM, Johnson CH Chen (陳昭勳) wrote: > Hi, > > Thanks for your good detailed suggestions! > Other feedback suggests to convert the driver to use the watchdog core in the rtc code. I would suggest to follow that suggestion. >>> + * It would be more efficient to use i2c msgs/i2c_tran

RE: [PATCH 3/3] watchdog: ds1374_wdt: Introduce Dallas/Maxim DS1374 Watchdog driver

2020-06-22 Thread 陳昭勳
Hi, Thanks for your good detailed suggestions! > > + * It would be more efficient to use i2c msgs/i2c_transfer directly > > +but, as > > + * recommened in .../Documentation/i2c/writing-clients section > > + * "Sending and receiving", using SMBus level communication is preferred. > > + */ > > + >

Re: [PATCH 3/3] watchdog: ds1374_wdt: Introduce Dallas/Maxim DS1374 Watchdog driver

2020-06-22 Thread Guenter Roeck
On 6/22/20 3:03 AM, Johnson CH Chen (陳昭勳) wrote: > Here provide Watchdog function from rtc-ds1374.c which is in RTC subsystem > originally. Besides, add nowayout and implement Watchdog margin time when > DS1374 Watchdog device is found. > > Signed-off-by: Johnson Chen > --- > drivers/watchdog/Kc

[PATCH 3/3] watchdog: ds1374_wdt: Introduce Dallas/Maxim DS1374 Watchdog driver

2020-06-22 Thread 陳昭勳
Here provide Watchdog function from rtc-ds1374.c which is in RTC subsystem originally. Besides, add nowayout and implement Watchdog margin time when DS1374 Watchdog device is found. Signed-off-by: Johnson Chen --- drivers/watchdog/Kconfig | 11 ++ drivers/watchdog/Makefile | 1 + dri