Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

2015-04-01 Thread Alexandre Belloni
Hi, On 31/03/2015 at 20:18:28 -0700, Joe Perches wrote : > Neither __func__ or __FILE__ is really useful here. > The message is already specific enough without it. > > If anything, it'd probably be better to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > to the various files in drivers

Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

2015-04-01 Thread Joe Perches
On Wed, 2015-04-01 at 09:05 +0200, Alessandro Zummo wrote: > On Tue, 31 Mar 2015 20:18:28 -0700 > Joe Perches wrote: > > > Neither __func__ or __FILE__ is really useful here. > > The message is already specific enough without it. > > > > If anything, it'd probably be better to add > > > > #defi

Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

2015-04-01 Thread Alessandro Zummo
On Tue, 31 Mar 2015 20:18:28 -0700 Joe Perches wrote: > Neither __func__ or __FILE__ is really useful here. > The message is already specific enough without it. > > If anything, it'd probably be better to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Seems reasonable given that pr_fmt i

Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

2015-03-31 Thread Joe Perches
On Wed, 2015-04-01 at 05:01 +0200, Alexandre Belloni wrote: > On 28/03/2015 at 23:09:36 +0200, Aaro Koskinen wrote : > > Use function name in the error log instead of __FILE__. > > Signed-off-by: Aaro Koskinen > Acked-by: Alexandre Belloni Hello. > > diff --git a/drivers/rtc/hctosys.c b/drivers

Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

2015-03-31 Thread Alexandre Belloni
On 28/03/2015 at 23:09:36 +0200, Aaro Koskinen wrote : > Use function name in the error log instead of __FILE__. > > Signed-off-by: Aaro Koskinen Acked-by: Alexandre Belloni > --- > drivers/rtc/hctosys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/hcto

[PATCH 3/3] rtc: hctosys: use function name in the error log

2015-03-28 Thread Aaro Koskinen
Use function name in the error log instead of __FILE__. Signed-off-by: Aaro Koskinen --- drivers/rtc/hctosys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/hctosys.c b/drivers/rtc/hctosys.c index 6c719f2..7748a61 100644 --- a/drivers/rtc/hctosys.c +++ b/drivers