Re: [PATCH 3/3] perf tools: include termios.h explicitly

2013-06-19 Thread Joonsoo Kim
On Wed, Jun 19, 2013 at 09:16:20PM +0900, Namhyung Kim wrote: > Hi Ingo, > > On Wed, Jun 19, 2013 at 8:33 PM, Ingo Molnar wrote: > > > > * Joonsoo Kim wrote: > > > >> Building perf for android is failed, because it can't find definition of > >> struct winsize. This definition is in termios.h, so

Re: [PATCH 3/3] perf tools: include termios.h explicitly

2013-06-19 Thread David Ahern
On 6/18/13 7:02 PM, Joonsoo Kim wrote: Building perf for android is failed, because it can't find definition of struct winsize. This definition is in termios.h, so I add this header to util.h to solve the problem. It is missed by commit '2c803e52' which moves get_term_dimensions() from builtin-to

Re: [PATCH 3/3] perf tools: include termios.h explicitly

2013-06-19 Thread Namhyung Kim
Hi Ingo, On Wed, Jun 19, 2013 at 8:33 PM, Ingo Molnar wrote: > > * Joonsoo Kim wrote: > >> Building perf for android is failed, because it can't find definition of >> struct winsize. This definition is in termios.h, so I add this header >> to util.h to solve the problem. It is missed by commit '

Re: [PATCH 3/3] perf tools: include termios.h explicitly

2013-06-19 Thread Ingo Molnar
* Joonsoo Kim wrote: > Building perf for android is failed, because it can't find definition of > struct winsize. This definition is in termios.h, so I add this header > to util.h to solve the problem. It is missed by commit '2c803e52' which > moves get_term_dimensions() from builtin-top.c to ut

[PATCH 3/3] perf tools: include termios.h explicitly

2013-06-18 Thread Joonsoo Kim
Building perf for android is failed, because it can't find definition of struct winsize. This definition is in termios.h, so I add this header to util.h to solve the problem. It is missed by commit '2c803e52' which moves get_term_dimensions() from builtin-top.c to util.c, but, missed to move termio