Re: [PATCH 3/3] perf/x86/intel: force resched when TFA sysctl is modified

2019-04-05 Thread Stephane Eranian
On Fri, Apr 5, 2019 at 1:26 PM Peter Zijlstra wrote: > > On Fri, Apr 05, 2019 at 10:00:03AM -0700, Stephane Eranian wrote: > > > > > +static void update_tfa_sched(void *ignored) > > > > +{ > > > > + struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events); > > > > + struct pmu *pmu = x86_

Re: [PATCH 3/3] perf/x86/intel: force resched when TFA sysctl is modified

2019-04-05 Thread Peter Zijlstra
On Fri, Apr 05, 2019 at 10:00:03AM -0700, Stephane Eranian wrote: > > > +static void update_tfa_sched(void *ignored) > > > +{ > > > + struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events); > > > + struct pmu *pmu = x86_get_pmu(); > > > + struct perf_cpu_context *cpuctx = > > > thi

Re: [PATCH 3/3] perf/x86/intel: force resched when TFA sysctl is modified

2019-04-05 Thread Stephane Eranian
On Fri, Apr 5, 2019 at 12:13 AM Peter Zijlstra wrote: > > On Thu, Apr 04, 2019 at 11:32:19AM -0700, Stephane Eranian wrote: > > diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c > > index a4b7711ef0ee..8d356c2096bc 100644 > > --- a/arch/x86/events/intel/core.c > > +++ b/arch

Re: [PATCH 3/3] perf/x86/intel: force resched when TFA sysctl is modified

2019-04-05 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 11:32:19AM -0700, Stephane Eranian wrote: > diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c > index a4b7711ef0ee..8d356c2096bc 100644 > --- a/arch/x86/events/intel/core.c > +++ b/arch/x86/events/intel/core.c > @@ -4483,6 +4483,60 @@ static ssize_t fr

[PATCH 3/3] perf/x86/intel: force resched when TFA sysctl is modified

2019-04-04 Thread Stephane Eranian
This patch provides guarantee to the sysadmin that when TFA is disabled, no PMU event is using PMC3 when the echo command returns. Vice-Versa, when TFA is enabled, PMU can use PMC3 immediately (to eliminate possible multiplexing). $ perf stat -a -I 1000 --no-merge -e branches,branches,branches,bra