Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-08 Thread Rob Herring
On Thu, Oct 06, 2016 at 08:47:13AM +0200, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Mark Rutland writes: > > > >> On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: > >>> Mark Rutland writes: > >>> > >>> reg-u16-align4 tells that a specific hardware doesn't support 16 b

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-08 Thread Rob Herring
On Mon, Oct 03, 2016 at 05:42:29PM +0100, Mark Rutland wrote: > On Mon, Oct 03, 2016 at 05:09:13PM +0100, Russell King - ARM Linux wrote: > > Please note that the binding doc for smsc,lan91c111.txt is slightly wrong > > on two counts: > > > > 1) compatible property: > > > > compatible = "smsc,lan

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-05 Thread Robert Jarzmik
Robert Jarzmik writes: > Mark Rutland writes: > >> On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: >>> Mark Rutland writes: >>> >>> reg-u16-align4 tells that a specific hardware doesn't support 16 bit writes >>> not >>> being 32 bits aligned, or said differently that a "store"

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Mark Rutland writes: > On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: >> Mark Rutland writes: >> >> reg-u16-align4 tells that a specific hardware doesn't support 16 bit writes >> not >> being 32 bits aligned, or said differently that a "store" 16 bits wide on an >> address of

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Mark Rutland
On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: > Mark Rutland writes: > > > On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: > >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > >> which must be aligned on 32 bits addresses. > >> > >> Si

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Mark Rutland
On Mon, Oct 03, 2016 at 05:09:13PM +0100, Russell King - ARM Linux wrote: > Please note that the binding doc for smsc,lan91c111.txt is slightly wrong > on two counts: > > 1) compatible property: > > compatible = "smsc,lan91c111"; > > vs the code: > > static const struct of_device_id smc91x_matc

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Jeremy Linton writes: > Hi Robert, > > On 10/03/2016 04:05 AM, Robert Jarzmik wrote: >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes >> which must be aligned on 32 bits addresses. >> >> Signed-off-by: Robert Jarzmik >> --- >> Documentation/devicetree/bindings/net/sms

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Mark Rutland writes: > On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes >> which must be aligned on 32 bits addresses. >> >> Signed-off-by: Robert Jarzmik >> --- >> Documentation/devicetree/bindings/net/

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Russell King - ARM Linux
On Mon, Oct 03, 2016 at 04:46:25PM +0100, Mark Rutland wrote: > On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: > > Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > > which must be aligned on 32 bits addresses. > > > > Signed-off-by: Robert Jarzmik > > --

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Mark Rutland
On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: > Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > which must be aligned on 32 bits addresses. > > Signed-off-by: Robert Jarzmik > --- > Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++ > 1 file c

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Jeremy Linton
Hi Robert, On 10/03/2016 04:05 AM, Robert Jarzmik wrote: Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++ 1 file changed, 2 insertio

[PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/sm