Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler

Hi Andreas, On 07/21/2015 01:46 PM, Andreas Fenkart wrote: > Hi Vignesh, > > Generally I don't like this patch, it will make it harder, not easier, > to maintain the omap hsmmc driver. Also given that the bug occurs > rarely, people will be reluctant to clean it up later or accept > patches. > >

Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler

Hi Vignesh, Generally I don't like this patch, it will make it harder, not easier, to maintain the omap hsmmc driver. Also given that the bug occurs rarely, people will be reluctant to clean it up later or accept patches. see also comments below 2015-06-22 15:18 GMT+02:00 Vignesh R : > > > On Su

Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler

Hi Andreas, Thanks for testing out these patches. On Sunday 21 June 2015 04:15 AM, Andreas Fenkart wrote: > I haven't managed to produce a hang without this patch Reproducing this hang is not straight forward. It takes 40-50 card insertion/removal to see this case (sometimes even 100 tries). >

Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler

I haven't managed to produce a hang without this patch see also comments below 2015-06-16 12:37 GMT+02:00 Vignesh R : > Usually when there is an error in transfer, DTO/CTO or other error > interrupts are raised. But if the card is unplugged in the middle of a > data transfer, it is observed that,

[PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler

Usually when there is an error in transfer, DTO/CTO or other error interrupts are raised. But if the card is unplugged in the middle of a data transfer, it is observed that, neither completion(success) or timeout(error) interrupts are raised. Hence, the mmc-core is waiting for-ever for the transfer