Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-19 Thread Michal Hocko
On Fri 16-10-15 15:12:23, Hugh Dickins wrote: [...] > Are you expecting to use mem_cgroup_from_kmem() from other places > in future? Seems possible; but at present it's called from only > one place, and (given how memcontrol.h has somehow managed to avoid > including mm.h all these years), I thoug

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-17 Thread Vladimir Davydov
On Fri, Oct 16, 2015 at 03:12:23PM -0700, Hugh Dickins wrote: ... > Are you expecting to use mem_cgroup_from_kmem() from other places > in future? Seems possible; but at present it's called from only Not in the near future. At least, currently I can't think of any other use for it except list_lru

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-16 Thread Andrew Morton
On Fri, 16 Oct 2015 15:12:23 -0700 (PDT) Hugh Dickins wrote: > > > --- a/include/linux/memcontrol.h > > > +++ b/include/linux/memcontrol.h > > > @@ -26,6 +26,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > > > Are you expecting t

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-16 Thread Johannes Weiner
On Fri, Oct 16, 2015 at 03:12:23PM -0700, Hugh Dickins wrote: > --- 4035m/mm/list_lru.c 2015-10-15 15:26:59.835572128 -0700 > +++ 4035M/mm/list_lru.c 2015-10-16 03:11:51.0 -0700 > @@ -63,6 +63,16 @@ list_lru_from_memcg_idx(struct list_lru_ > return &nlru->lru; > } > > +

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-16 Thread Hugh Dickins
On Fri, 16 Oct 2015, Vladimir Davydov wrote: > On Fri, Oct 16, 2015 at 04:17:26PM +0300, Kirill A. Shutemov wrote: > > On Mon, Oct 05, 2015 at 01:21:43AM +0300, Vladimir Davydov wrote: > > > Before the previous patch, __mem_cgroup_from_kmem had to handle two > > > types of kmem - slab pages and pag

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-16 Thread Michal Hocko
On Fri 16-10-15 16:17:26, Kirill A. Shutemov wrote: [...] I've just encountered the same while updating mmotm git tree. Thanks for the fix. All other configs which I am testing are good as well. > virt_to_head_page() is defined in but you don't include it, > and the commit breaks build for me (o

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-16 Thread Vladimir Davydov
On Fri, Oct 16, 2015 at 04:17:26PM +0300, Kirill A. Shutemov wrote: > On Mon, Oct 05, 2015 at 01:21:43AM +0300, Vladimir Davydov wrote: > > Before the previous patch, __mem_cgroup_from_kmem had to handle two > > types of kmem - slab pages and pages allocated with alloc_kmem_pages - > > differently,

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-16 Thread Kirill A. Shutemov
On Mon, Oct 05, 2015 at 01:21:43AM +0300, Vladimir Davydov wrote: > Before the previous patch, __mem_cgroup_from_kmem had to handle two > types of kmem - slab pages and pages allocated with alloc_kmem_pages - > differently, because slab pages did not store information about owner > memcg in the pag

Re: [PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-08 Thread Michal Hocko
On Mon 05-10-15 01:21:43, Vladimir Davydov wrote: > Before the previous patch, __mem_cgroup_from_kmem had to handle two > types of kmem - slab pages and pages allocated with alloc_kmem_pages - > differently, because slab pages did not store information about owner > memcg in the page struct. Now we

[PATCH 3/3] memcg: simplify and inline __mem_cgroup_from_kmem

2015-10-04 Thread Vladimir Davydov
Before the previous patch, __mem_cgroup_from_kmem had to handle two types of kmem - slab pages and pages allocated with alloc_kmem_pages - differently, because slab pages did not store information about owner memcg in the page struct. Now we can unify it. Since after it, this function becomes tiny