Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-03-01 Thread Maxime Ripard
On Thu, Mar 01, 2018 at 11:32:32AM +, Andre Przywara wrote: > Hi, > > On 01/03/18 10:32, Maxime Ripard wrote: > > On Wed, Feb 28, 2018 at 11:19:11AM -0600, Samuel Holland wrote: > >> Hi, > >> > >> On 02/28/18 02:32, Maxime Ripard wrote: > >>> On Tue, Feb 27, 2018 at 08:27:14PM -0600, Samuel Ho

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-03-01 Thread Andre Przywara
Hi, On 01/03/18 10:32, Maxime Ripard wrote: > On Wed, Feb 28, 2018 at 11:19:11AM -0600, Samuel Holland wrote: >> Hi, >> >> On 02/28/18 02:32, Maxime Ripard wrote: >>> On Tue, Feb 27, 2018 at 08:27:14PM -0600, Samuel Holland wrote: + /* + * The failure path should not disable the clock

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-03-01 Thread Maxime Ripard
On Wed, Feb 28, 2018 at 11:19:11AM -0600, Samuel Holland wrote: > Hi, > > On 02/28/18 02:32, Maxime Ripard wrote: > > On Tue, Feb 27, 2018 at 08:27:14PM -0600, Samuel Holland wrote: > >> + /* > >> + * The failure path should not disable the clock or assert the reset, > >> + * because the PSCI

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Jassi Brar
On Thu, Mar 1, 2018 at 12:26 AM, Samuel Holland wrote: > On 02/28/18 12:14, Jassi Brar wrote: >> On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: >>> Hi, >>> >>> On 02/28/18 03:16, Jassi Brar wrote: On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: > +/*

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Samuel Holland
On 02/28/18 12:14, Jassi Brar wrote: > On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: >> Hi, >> >> On 02/28/18 03:16, Jassi Brar wrote: >>> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: >>> >>> +/* + * The message box hardware provides 8 unidirectional channels. A

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Jassi Brar
On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: > Hi, > > On 02/28/18 03:16, Jassi Brar wrote: >> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: >> >> >>> +/* >>> + * The message box hardware provides 8 unidirectional channels. As the >>> mailbox >>> + * framework expects th

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Samuel Holland
Hi, On 02/28/18 03:16, Jassi Brar wrote: > On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: > > >> +/* >> + * The message box hardware provides 8 unidirectional channels. As the >> mailbox >> + * framework expects them to be bidirectional >> > That is incorrect. Mailbox framework doe

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Samuel Holland
Hi, On 02/28/18 02:32, Maxime Ripard wrote: > On Tue, Feb 27, 2018 at 08:27:14PM -0600, Samuel Holland wrote: >> +/* >> + * The failure path should not disable the clock or assert the reset, >> + * because the PSCI implementation in firmware relies on this device >> + * being funct

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Jassi Brar
On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: > +/* > + * The message box hardware provides 8 unidirectional channels. As the > mailbox > + * framework expects them to be bidirectional > That is incorrect. Mailbox framework does not require a channel to be TX and RX capable. You s

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Maxime Ripard
On Tue, Feb 27, 2018 at 08:27:14PM -0600, Samuel Holland wrote: > + /* > + * The failure path should not disable the clock or assert the reset, > + * because the PSCI implementation in firmware relies on this device > + * being functional. Claiming the clock in this driver is req

[PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-27 Thread Samuel Holland
Recent Allwinner sunxi SoCs contain a "hardware message box" used for communication between the ARM CPUs and the ARISC management processor (the platform's equivalent of the ARM SCP). Add a driver for it, so it can be used for SCPI or other communication protocols. The hardware contains 8 unidirec