Re: [PATCH 3/3] i2c-axxia: support sequence command mode

2018-12-11 Thread Wolfram Sang
Hi, > +static void axxia_i2c_handle_seq_nak(struct axxia_i2c_dev *idev) > +{ > + while (readl(idev->base + MST_COMMAND) & CMD_BUSY) > + udelay(100); > +} My code checkers rightfully complain about this: CHECKPATCH CHECK: usleep_range is preferred over udelay; see Documentation

Re: [PATCH 3/3] i2c-axxia: support sequence command mode

2018-12-11 Thread Sverdlin, Alexander (Nokia - DE/Ulm)
Hi! On 10/12/2018 16:05, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > In order to comply with SMBus specification, the Axxia I²C module will > abort the multi message transfer if the delay between finishing sending > one message and starting another is longer than 25ms. Unfortunately it > isn'

[PATCH 3/3] i2c-axxia: support sequence command mode

2018-12-10 Thread Adamski, Krzysztof (Nokia - PL/Wroclaw)
In order to comply with SMBus specification, the Axxia I²C module will abort the multi message transfer if the delay between finishing sending one message and starting another is longer than 25ms. Unfortunately it isn't that hard to trigger this situation on a busy system. In order to fix this prob