Re: [PATCH 3/3] drm/panel: Add Rocktech jh057n00900 panel driver

2019-02-24 Thread Guido Günther
Hi Sam, On Sat, Feb 23, 2019 at 11:03:04PM +0100, Sam Ravnborg wrote: > Hi Guido. > > Thanks for this patch. > See below for some review feedback. Thanks for having look! This is what I've folded in for v2: Changes from v1 * As per review comments from Sam Ravnborg * Make SPDX-License-Identifi

Re: [PATCH 3/3] drm/panel: Add Rocktech jh057n00900 panel driver

2019-02-23 Thread Sam Ravnborg
Hi Guido. Thanks for this patch. See below for some review feedback. The driver includes the "allpixelson_set" debugfs feature. Is this a debug leftover, or is there a real need for this? If this is a debug feature that is no logner needed then no need to add it to the mainline driver. S

[PATCH 3/3] drm/panel: Add Rocktech jh057n00900 panel driver

2019-02-23 Thread Guido Günther
Support Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel. It is a MIPI DSI video mode panel. The panel seems to use a Sitronix ST7703 look alike (most of the commands look similar to the ST7703's data sheet but use a different number of parameters). The initial version of the DSI init sequence (in