Re: [PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-26 Thread jbrunet
On Sat, 2018-07-21 at 23:34 +0200, Martin Blumenstingl wrote: > On Sat, Jul 21, 2018 at 10:46 PM Jerome Brunet wrote: > > > > On Sat, 2018-07-21 at 22:16 +0200, Martin Blumenstingl wrote: > > > > We could even add ranges instead of table when we know the PLL supports > > > > a well-known continu

Re: [PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-21 Thread Martin Blumenstingl
Hi Jerome, On Sat, Jul 21, 2018 at 10:46 PM Jerome Brunet wrote: > > On Sat, 2018-07-21 at 22:16 +0200, Martin Blumenstingl wrote: > > > We could even add ranges instead of table when we know the PLL supports a > > > well-known continuous dividers range. > > > > I had a look at the sys_pll setti

Re: [PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-21 Thread Jerome Brunet
On Sat, 2018-07-21 at 22:16 +0200, Martin Blumenstingl wrote: > > We could even add ranges instead of table when we know the PLL supports a > > well-known continuous dividers range. > > I had a look at the sys_pll settings on Meson8b, here's what > Meson8/Meson8b/Meson8m2 support for sys_pll: > -

Re: [PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-21 Thread Martin Blumenstingl
On Thu, Jul 19, 2018 at 10:44 AM Neil Armstrong wrote: > > On 17/07/2018 11:56, Jerome Brunet wrote: > > Putting hard-coded rates inside the parameter tables assumes that > > the parent is known and will never change. That's a big assumption > > we should not make. > > > > We have everything we ne

Re: [PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-19 Thread Jerome Brunet
On Thu, 2018-07-19 at 10:44 +0200, Neil Armstrong wrote: > We could even add ranges instead of table when we know the PLL supports a > well-known continuous dividers range. I was thinking about this too. I did not went for it because it would mean yet another rework of the pll driver, which I did

Re: [PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-19 Thread Neil Armstrong
On 17/07/2018 11:56, Jerome Brunet wrote: > Putting hard-coded rates inside the parameter tables assumes that > the parent is known and will never change. That's a big assumption > we should not make. > > We have everything we need to recalculate the output rate using > the parent rate and the res

[PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-17 Thread Jerome Brunet
Putting hard-coded rates inside the parameter tables assumes that the parent is known and will never change. That's a big assumption we should not make. We have everything we need to recalculate the output rate using the parent rate and the rest of the parameters. Let's do so and drop the rates fr