Re: [PATCH 3/3] bitmap: break kunit into test cases

2025-02-09 Thread Muhammad Usama Anjum
On 2/8/25 1:14 AM, Tamir Duberstein wrote: > Move some tests into `bitmap_test_cases` and parameterize > `test_bitmap_print_buf`. This gives us nicer output in the event of a > failure. > > Signed-off-by: Tamir Duberstein Reviewed-by: Muhammad Usama Anjum > --- > lib/bitmap_kunit.c | 182 > ++

Re: [PATCH 3/3] bitmap: break kunit into test cases

2025-02-08 Thread Tamir Duberstein
On Sat, Feb 8, 2025 at 4:07 AM David Gow wrote: > > On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein wrote: > > > > Move some tests into `bitmap_test_cases` and parameterize > > `test_bitmap_print_buf`. This gives us nicer output in the event of a > > failure. > > > > Signed-off-by: Tamir Duberstein

Re: [PATCH 3/3] bitmap: break kunit into test cases

2025-02-08 Thread David Gow
On Sat, 8 Feb 2025 at 04:14, Tamir Duberstein wrote: > > Move some tests into `bitmap_test_cases` and parameterize > `test_bitmap_print_buf`. This gives us nicer output in the event of a > failure. > > Signed-off-by: Tamir Duberstein > --- I very much like this cleanup: the static global 'kunitt

[PATCH 3/3] bitmap: break kunit into test cases

2025-02-07 Thread Tamir Duberstein
Move some tests into `bitmap_test_cases` and parameterize `test_bitmap_print_buf`. This gives us nicer output in the event of a failure. Signed-off-by: Tamir Duberstein --- lib/bitmap_kunit.c | 182 ++--- 1 file changed, 89 insertions(+), 93 deleti