Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-08 Thread Greg Kroah-Hartman
On Thu, Apr 08, 2021 at 01:59:43PM +0200, Oliver Neukum wrote: > Am Donnerstag, den 08.04.2021, 13:54 +0200 schrieb Johan Hovold: > > On Thu, Apr 08, 2021 at 01:34:12PM +0200, Oliver Neukum wrote: > > > Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold: > > > > On Thu, Apr 08, 2021 at

Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-08 Thread Oliver Neukum
Am Donnerstag, den 08.04.2021, 13:54 +0200 schrieb Johan Hovold: > On Thu, Apr 08, 2021 at 01:34:12PM +0200, Oliver Neukum wrote: > > Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold: > > > On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote: > > > > Am Mittwoch, den 07.04.

Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-08 Thread Johan Hovold
On Thu, Apr 08, 2021 at 01:34:12PM +0200, Oliver Neukum wrote: > Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold: > > On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote: > > > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > > > > Well, the devices report

Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-08 Thread Oliver Neukum
Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold: > On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote: > > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > > Well, the devices report it. It is part of the standard. > > No, the standard doesn't include an

Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-08 Thread Johan Hovold
On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote: > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most > > serial devices is only useful for setting the close_delay and > > closing_wait parameters.

Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-08 Thread Oliver Neukum
Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most > serial devices is only useful for setting the close_delay and > closing_wait parameters. > > The xmit_fifo_size parameter could be used to set the hardware tr

[PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

2021-04-07 Thread Johan Hovold
TIOCSSERIAL is a horrid, underspecified, legacy interface which for most serial devices is only useful for setting the close_delay and closing_wait parameters. The xmit_fifo_size parameter could be used to set the hardware transmit fifo size of a legacy UART when it could not be detected, but the