Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-09-01 Thread Michal Simek
On 08/30/2014 02:43 AM, Florian Fainelli wrote: > On 08/29/2014 04:22 PM, Jason Gunthorpe wrote: >> On Fri, Aug 29, 2014 at 11:23:57AM -0700, Florian Fainelli wrote: >>> On 08/29/2014 10:31 AM, Jason Gunthorpe wrote: On Fri, Aug 29, 2014 at 08:35:36AM -0700, Sören Brinkmann wrote: > T

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Florian Fainelli
On 08/29/2014 04:22 PM, Jason Gunthorpe wrote: > On Fri, Aug 29, 2014 at 11:23:57AM -0700, Florian Fainelli wrote: >> On 08/29/2014 10:31 AM, Jason Gunthorpe wrote: >>> On Fri, Aug 29, 2014 at 08:35:36AM -0700, Sören Brinkmann wrote: >>> The compatible string is listed as optional property for

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Jason Gunthorpe
On Fri, Aug 29, 2014 at 11:23:57AM -0700, Florian Fainelli wrote: > On 08/29/2014 10:31 AM, Jason Gunthorpe wrote: > > On Fri, Aug 29, 2014 at 08:35:36AM -0700, Sören Brinkmann wrote: > > > >> The compatible string is listed as optional property for PHYs. So, not > >> having one is an option, I gu

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Florian Fainelli
On 08/29/2014 10:31 AM, Jason Gunthorpe wrote: > On Fri, Aug 29, 2014 at 08:35:36AM -0700, Sören Brinkmann wrote: > >> The compatible string is listed as optional property for PHYs. So, not >> having one is an option, I guess. But, I'd also prefer to at least keep >> the -c22 one, since I saw prob

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Jason Gunthorpe
On Fri, Aug 29, 2014 at 08:35:36AM -0700, Sören Brinkmann wrote: > The compatible string is listed as optional property for PHYs. So, not > having one is an option, I guess. But, I'd also prefer to at least keep > the -c22 one, since I saw problems when I tried using -c45 (the Zed phy > should sup

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Andreas Färber
Am 29.08.2014 17:35, schrieb Sören Brinkmann: > On Fri, 2014-08-29 at 05:18PM +0200, Andreas Färber wrote: >> Am 29.08.2014 16:08, schrieb Michal Simek: >>> I think resolution is: >>> 1. Do not use marvell,88e1518 because it is not listed anywhere >>> 2. Do not add ethernet-phy-id. because

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Sören Brinkmann
On Fri, 2014-08-29 at 05:18PM +0200, Andreas Färber wrote: > Am 29.08.2014 16:08, schrieb Michal Simek: > > On 08/25/2014 10:21 PM, Florian Fainelli wrote: > >> On 08/25/2014 10:46 AM, Jason Gunthorpe wrote: > >>> On Fri, Aug 22, 2014 at 01:47:09PM -0700, Florian Fainelli wrote: > >>> > > - th

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Andreas Färber
Am 29.08.2014 16:08, schrieb Michal Simek: > On 08/25/2014 10:21 PM, Florian Fainelli wrote: >> On 08/25/2014 10:46 AM, Jason Gunthorpe wrote: >>> On Fri, Aug 22, 2014 at 01:47:09PM -0700, Florian Fainelli wrote: >>> > - the ID based strings seem to be not needed since, IIUC, the core >

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-29 Thread Michal Simek
On 08/25/2014 10:21 PM, Florian Fainelli wrote: > On 08/25/2014 10:46 AM, Jason Gunthorpe wrote: >> On Fri, Aug 22, 2014 at 01:47:09PM -0700, Florian Fainelli wrote: >> - the ID based strings seem to be not needed since, IIUC, the core reads the ID from the PHY and uses it, so I just

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-25 Thread Florian Fainelli
On 08/25/2014 10:46 AM, Jason Gunthorpe wrote: > On Fri, Aug 22, 2014 at 01:47:09PM -0700, Florian Fainelli wrote: > >>> - the ID based strings seem to be not needed since, IIUC, the core >>>reads the ID from the PHY and uses it, so I just left it out not >>>trying to figure out how to ob

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-25 Thread Jason Gunthorpe
On Fri, Aug 22, 2014 at 01:47:09PM -0700, Florian Fainelli wrote: > > - the ID based strings seem to be not needed since, IIUC, the core > >reads the ID from the PHY and uses it, so I just left it out not > >trying to figure out how to obtain the correct ID > > It is not needed, but it i

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-22 Thread Florian Fainelli
2014-08-21 8:49 GMT-07:00 Sören Brinkmann : > On Thu, 2014-08-21 at 01:32PM +0200, Andreas Färber wrote: >> Am 21.08.2014 10:41, schrieb Michal Simek: >> > On 08/20/2014 05:56 PM, Soren Brinkmann wrote: >> >> Add missing Ethernet phys to Zynq DTs. >> >> >> >> Signed-off-by: Soren Brinkmann >> >> -

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-22 Thread Jason Gunthorpe
On Fri, Aug 22, 2014 at 09:31:20AM -0700, Sören Brinkmann wrote: > > > - the marvell compatible strings are used in our vendor tree. They > > >aren't used anywhere but in our vendor tree. I though keeping them is > > >nice since it identifies the PHY fully. And in case that level of > > >

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-22 Thread Sören Brinkmann
On Fri, 2014-08-22 at 10:20AM -0600, Jason Gunthorpe wrote: > On Thu, Aug 21, 2014 at 08:49:19AM -0700, Sören Brinkmann wrote: > > > So my thinkings: > > - the compatible string with the -c22 is used and documented in the phy > >bindings, it should be there. > > Yes > > > - the ID based st

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-22 Thread Jason Gunthorpe
On Thu, Aug 21, 2014 at 08:49:19AM -0700, Sören Brinkmann wrote: > So my thinkings: > - the compatible string with the -c22 is used and documented in the phy >bindings, it should be there. Yes > - the ID based strings seem to be not needed since, IIUC, the core >reads the ID from the P

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-21 Thread Sören Brinkmann
On Thu, 2014-08-21 at 01:32PM +0200, Andreas Färber wrote: > Am 21.08.2014 10:41, schrieb Michal Simek: > > On 08/20/2014 05:56 PM, Soren Brinkmann wrote: > >> Add missing Ethernet phys to Zynq DTs. > >> > >> Signed-off-by: Soren Brinkmann > >> --- > >> arch/arm/boot/dts/zynq-zc702.dts | 6 ++

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-21 Thread Andreas Färber
Am 21.08.2014 10:41, schrieb Michal Simek: > On 08/20/2014 05:56 PM, Soren Brinkmann wrote: >> Add missing Ethernet phys to Zynq DTs. >> >> Signed-off-by: Soren Brinkmann >> --- >> arch/arm/boot/dts/zynq-zc702.dts | 6 ++ >> arch/arm/boot/dts/zynq-zc706.dts | 6 ++ >> arch/arm/boot/dts/zy

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-21 Thread Michal Simek
On 08/20/2014 05:56 PM, Soren Brinkmann wrote: > Add missing Ethernet phys to Zynq DTs. > > Signed-off-by: Soren Brinkmann > --- > arch/arm/boot/dts/zynq-zc702.dts | 6 ++ > arch/arm/boot/dts/zynq-zc706.dts | 6 ++ > arch/arm/boot/dts/zynq-zed.dts | 6 ++ > 3 files changed, 18 inse

[PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-20 Thread Soren Brinkmann
Add missing Ethernet phys to Zynq DTs. Signed-off-by: Soren Brinkmann --- arch/arm/boot/dts/zynq-zc702.dts | 6 ++ arch/arm/boot/dts/zynq-zc706.dts | 6 ++ arch/arm/boot/dts/zynq-zed.dts | 6 ++ 3 files changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch