Re: [PATCH 3/27] Add MAD helper functions

2005-07-12 Thread Alexey Dobriyan
On Wednesday 13 July 2005 02:17, Michael S. Tsirkin wrote: > Quoting r. Tom Duffy <[EMAIL PROTECTED]>: > > These seem to be mostly coming from cpu_to_be*() and be*_to_cpu(). Is > > there a good rule of thumb for fixing these warnings? > > Yes. > Use attributes like __be32 and friends appropriatel

Re: Re: [PATCH 3/27] Add MAD helper functions

2005-07-12 Thread Michael S. Tsirkin
Quoting r. Tom Duffy <[EMAIL PROTECTED]>: > These seem to be mostly coming from cpu_to_be*() and be*_to_cpu(). Is > there a good rule of thumb for fixing these warnings? Yes. Use attributes like __be32 and friends appropriately. -- MST - To unsubscribe from this list: send the line "unsubscribe

Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions

2005-07-12 Thread Tom Duffy
On Mon, 2005-07-11 at 22:38 +0400, Alexey Dobriyan wrote: > $ make allmodconfig >/dev/null > $ make C=2 CHECK="sparse -Wbitwise" drivers/infiniband/ 2>&1 | tee > ../W_infiniband > [snip] > $ grep -c "warning: " ../W_infiniband > 430 These seem to be mostly coming from cpu_to_be*() and be*_t

Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Alexey Dobriyan
On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > Add new helper routines for allocating MADs for sending and formatting > a send WR. > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c > +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c ^^

Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Alexey Dobriyan
On Monday 11 July 2005 21:52, Tom Duffy wrote: > Alexey Dobriyan wrote: > > >unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings > >is not a reason to add more. > > > > > Can you please elaborate on the sparse warnings that you are seeing > throughout the rest of infini

Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > Add new helper routines for allocating MADs for sending and formatting > > a send WR. > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c > > +++ linux-2.6.13-rc2-mm1/drivers/infi

Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Tom Duffy
Alexey Dobriyan wrote: unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings is not a reason to add more. Can you please elaborate on the sparse warnings that you are seeing throughout the rest of infiniband? Thanks, -tduffy - To unsubscribe from this list: send the

Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 12:29, Alexey Dobriyan wrote: > On Monday 11 July 2005 19:30, Hal Rosenstock wrote: > > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > > Add new helper routines for allocating MADs for sending and formatting

Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Alexey Dobriyan
On Monday 11 July 2005 19:30, Hal Rosenstock wrote: > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > Add new helper routines for allocating MADs for sending and formatting > > > a send WR. > > > > > -- linux-2.6.13-rc2-mm1/drivers/

Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
On Mon, 2005-07-11 at 12:05, Nishanth Aravamudan wrote: > On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: > > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c > > > > ++

Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Nishanth Aravamudan
On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > Add new helper routines for allocating MADs for sending and formatting > > > a send WR. > > > > > -- linux-2.6.13-rc2-mm1/driver

[PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Hal Rosenstock
Add new helper routines for allocating MADs for sending and formatting a send WR. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 2/27. -- core/mad.c | 76 +++