Re: [PATCH 28/36] Use menuconfig objects II - sound

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 16:19, Johannes Berg wrote: > >For the aoa bits this ends up having two "Apple Onboard Audio driver" >bits which is a bit confusing. Hold it hold it. You confuse the hell out of me. :p There is exactly one SND_AOA in my patch, where do you see the second menu entry in menuconfig? (

Re: [PATCH 28/36] Use menuconfig objects II - sound

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 17:12, Jan Engelhardt wrote: >On Apr 30 2007 16:19, Johannes Berg wrote: >> >>For the aoa bits this ends up having two "Apple Onboard Audio driver" >>bits which is a bit confusing. > >Hold it hold it. You confuse the hell out of me. :p >There is exactly one SND_AOA in my patch, where

Re: [PATCH 28/36] Use menuconfig objects II - sound

2007-04-30 Thread Johannes Berg
On Mon, 2007-04-30 at 16:45 +0200, Jan Engelhardt wrote: > >+config SND_AOA_CORE > >+tristate > > Why the extra AOA_CORE? Are there some options that require only AOA > but not AOA_CORE? Oh, I did the extra AOA_CORE so that AOA doesn't affect the build at all and because it's useless to buil

Re: [PATCH 28/36] Use menuconfig objects II - sound

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 16:19, Johannes Berg wrote: > >> --- linux-2.6.21-mm_20070428.orig/sound/aoa/Kconfig >> +++ linux-2.6.21-mm_20070428/sound/aoa/Kconfig >> @@ -1,9 +1,12 @@ >[...] > >For the aoa bits this ends up having two "Apple Onboard Audio driver" >bits which is a bit confusing. What, where? Oh

Re: [PATCH 28/36] Use menuconfig objects II - sound

2007-04-30 Thread Johannes Berg
> For the aoa bits this ends up having two "Apple Onboard Audio driver" > bits which is a bit confusing. How about this instead? I can of course do that on top of your change instead if that's easier to handle. johannes signature.asc Description: This is a digitally signed message part

Re: [PATCH 28/36] Use menuconfig objects II - sound

2007-04-30 Thread Johannes Berg
Jan, Thanks for doing this. > --- linux-2.6.21-mm_20070428.orig/sound/aoa/Kconfig > +++ linux-2.6.21-mm_20070428/sound/aoa/Kconfig > @@ -1,9 +1,12 @@ [...] For the aoa bits this ends up having two "Apple Onboard Audio driver" bits which is a bit confusing. How about this instead? SND_AOA was pre

[PATCH 28/36] Use menuconfig objects II - sound

2007-04-30 Thread Jan Engelhardt
CONFIG_SOUND, CONFIG_SND, CONFIG_SOUND_PRIME, ...: Change Kconfig objects from "menu, config" into "menuconfig" so that the user can disable the whole feature without having to enter the menu first. CONFIG_SND_*_DRIVERS: Make a "menuconfig" out of the Kconfig objects "menu, ..., endmenu", so that