On Fri, Dec 08, 2006 at 07:03:00PM +0100, Jan Engelhardt wrote:
> On Dec 8 2006 12:43, Josef Sipek wrote:
...
> >args->err is modified. If args is declared const, gcc complains.
>
> I never said making "args" const, but
> rather [-> http://lkml.org/lkml/2006/12/5/210 ] I said:
>
> "Care to make
On Dec 8 2006 12:43, Josef Sipek wrote:
>> On Dec 8 2006 11:00, Josef Sipek wrote:
>>
>> +void __unionfs_mkdir(void *data)
>> +{
>> +struct sioq_args *args = data;
>> +struct mkdir_args *m = &args->mkdir;
>> +
>> +args->err = vfs_mkdir(m->parent, m->dentry, m->mode);
>> +complete(
On Fri, Dec 08, 2006 at 06:02:28PM +0100, Jan Engelhardt wrote:
>
> On Dec 8 2006 11:00, Josef Sipek wrote:
>
> +void __unionfs_mkdir(void *data)
> +{
> + struct sioq_args *args = data;
> + struct mkdir_args *m = &args->mkdir;
> +
> + args->err = vfs_mkdir(m->parent, m->dentry, m->mod
On Dec 8 2006 11:00, Josef Sipek wrote:
+void __unionfs_mkdir(void *data)
+{
+ struct sioq_args *args = data;
+ struct mkdir_args *m = &args->mkdir;
+
+ args->err = vfs_mkdir(m->parent, m->dentry, m->mode);
+ complete(&args->comp);
+}
>> The members of m (i.e. m->*) are n
On Fri, Dec 08, 2006 at 11:38:13AM +0100, Jan Engelhardt wrote:
>
> On Dec 7 2006 21:17, Josef Sipek wrote:
> >> >> > >+void __unionfs_mknod(void *data)
> >> >> > >+{
> >> >> > >+struct sioq_args *args = data;
> >> >> > >+struct mknod_args *m = &args->mknod;
>
> ...
> | vfs_mknod(m->p
On Dec 7 2006 21:17, Josef Sipek wrote:
>> >> > >+void __unionfs_mknod(void *data)
>> >> > >+{
>> >> > >+ struct sioq_args *args = data;
>> >> > >+ struct mknod_args *m = &args->mknod;
...
| vfs_mknod(m->parent, m->dentry, m->mode, m->dev);
>> >If I make the *args = data line const
On Wed, Dec 06, 2006 at 07:46:50PM +0100, Jan Engelhardt wrote:
> I smell a big conspiracy! So yet again it's mixed mixed
>
> fs$ grep __init */*.c | grep -v ' init_'
> sysfs/mount.c:int __init sysfs_init(void)
> sysv/inode.c:int __init sysv_init_icache(void)
> proc/vmcore.c:static int __init vmco
On Dec 6 2006 12:32, Josef Sipek wrote:
>> > >+int __init init_sioq(void)
>> >
>> > Although it's just me, I'd prefer sioq_init(), sioq_exit(),
>> > sioq_run(), etc. to go in hand with what most drivers use as naming
>> > (i.e. "_" ).
>>
>> That makes sense.
>
>Hrm. Looking at the code, I noti
On Tue, Dec 05, 2006 at 02:50:13PM -0500, Josef Sipek wrote:
> On Tue, Dec 05, 2006 at 08:27:51PM +0100, Jan Engelhardt wrote:
> >
> > On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote:
> > >+#include "union.h"
> > >+
> > >+struct workqueue_struct *sioq;
> > >+
> > >+int __init init_sioq(void)
> >
>
On Tue, Dec 05, 2006 at 08:27:51PM +0100, Jan Engelhardt wrote:
>
> On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote:
> >+#include "union.h"
> >+
> >+struct workqueue_struct *sioq;
> >+
> >+int __init init_sioq(void)
>
> Although it's just me, I'd prefer sioq_init(), sioq_exit(),
> sioq_run(), etc.
On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote:
>+#include "union.h"
>+
>+struct workqueue_struct *sioq;
>+
>+int __init init_sioq(void)
Although it's just me, I'd prefer sioq_init(), sioq_exit(),
sioq_run(), etc. to go in hand with what most drivers use as naming
(i.e. "_" ).
>+ sioq = cre
From: Josef "Jeff" Sipek <[EMAIL PROTECTED]>
Workqueue & helper functions used to perform privileged operations on
behalf of the user process.
Signed-off-by: Josef "Jeff" Sipek <[EMAIL PROTECTED]>
Signed-off-by: David Quigley <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
12 matches
Mail list logo
