Re: [PATCH 24/27] tracing: Remove use of seq_printf return value

2015-02-23 Thread Joe Perches
On Mon, 2015-02-23 at 12:20 -0500, Steven Rostedt wrote: > On Sun, 22 Feb 2015 02:39:38 -0800 > Joe Perches wrote: > > > > FWIW, this one should be Cc:stable - it's a plain and simple bugfix > > > (so are all of those that used to return the result of seq_printf() from > > > ->show()). > > > > N

Re: [PATCH 24/27] tracing: Remove use of seq_printf return value

2015-02-23 Thread Steven Rostedt
On Sun, 22 Feb 2015 02:39:38 -0800 Joe Perches wrote: > > FWIW, this one should be Cc:stable - it's a plain and simple bugfix > > (so are all of those that used to return the result of seq_printf() from > > ->show()). > > Nah, it's not really a bugfix here. > > Patches sent to stable should fix

Re: [PATCH 24/27] tracing: Remove use of seq_printf return value

2015-02-22 Thread Joe Perches
On Sun, 2015-02-22 at 04:41 +, Al Viro wrote: > On Sat, Feb 21, 2015 at 10:54:09PM -0500, Steven Rostedt wrote: > > On Sat, 21 Feb 2015 18:53:51 -0800 Joe Perches wrote: > > > > > The seq_printf return value, because it's frequently misused, > > > will eventually be converted to void. > > >

Re: [PATCH 24/27] tracing: Remove use of seq_printf return value

2015-02-21 Thread Al Viro
On Sat, Feb 21, 2015 at 10:54:09PM -0500, Steven Rostedt wrote: > On Sat, 21 Feb 2015 18:53:51 -0800 > Joe Perches wrote: > > > The seq_printf return value, because it's frequently misused, > > will eventually be converted to void. > > > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow

Re: [PATCH 24/27] tracing: Remove use of seq_printf return value

2015-02-21 Thread Steven Rostedt
On Sat, 21 Feb 2015 18:53:51 -0800 Joe Perches wrote: > The seq_printf return value, because it's frequently misused, > will eventually be converted to void. > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to > seq_has_overflowed() and make public") > > Miscellanea: > > o R

[PATCH 24/27] tracing: Remove use of seq_printf return value

2015-02-21 Thread Joe Perches
The seq_printf return value, because it's frequently misused, will eventually be converted to void. See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to seq_has_overflowed() and make public") Miscellanea: o Remove unused return value from trace_lookup_stack Signed-off-by: Joe Perc