Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-02-07 Thread David Howells
Chuck Lever <[EMAIL PROTECTED]> wrote: > > @@ -95,12 +100,25 @@ struct nfs_server { > > unsigned intacdirmin; > > unsigned intacdirmax; > > unsigned intnamelen; > > + unsigned intoptions;/* extra options enabled by > > mount */

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-31 Thread David Howells
Chuck Lever <[EMAIL PROTECTED]> wrote: > >>> +struct nfs_fh_auxdata { > >>> + struct timespec i_mtime; > >>> + struct timespec i_ctime; > >>> + loff_t i_size; > >>> +}; > >> > >> It might be useful to explain here why you need to supplement the > >> mtime, ctime, and size fields that alre

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-30 Thread Chuck Lever
Hi David- On Jan 29, 2008, at 10:25 PM, David Howells wrote: Chuck Lever <[EMAIL PROTECTED]> wrote: This patch really ought to be broken into more manageable atomic changes to make it easier to review, and to provide more fine-grained explanation and rationalization for each specific change via

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-29 Thread Trond Myklebust
On Wed, 2008-01-30 at 03:25 +, David Howells wrote: > Chuck Lever <[EMAIL PROTECTED]> wrote: > > > This patch really ought to be broken into more manageable atomic > > changes to make it easier to review, and to provide more fine-grained > > explanation and rationalization for each specific c

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-29 Thread David Howells
Chuck Lever <[EMAIL PROTECTED]> wrote: > This patch really ought to be broken into more manageable atomic > changes to make it easier to review, and to provide more fine-grained > explanation and rationalization for each specific change via > individual patch descriptions. Hmmm I broke the

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-24 Thread Chuck Lever
Some comments below. This patch really ought to be broken into more manageable atomic changes to make it easier to review, and to provide more fine-grained explanation and rationalization for each specific change via individual patch descriptions. David Howells wrote: The attached patch mak

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-24 Thread Trond Myklebust
On Wed, 2008-01-23 at 17:22 +, David Howells wrote: > The attached patch makes it possible for the NFS filesystem to make use of the > network filesystem local caching service (FS-Cache). > > To be able to use this, an updated mount program is required. This can be > obtained from: > >

[PATCH 24/27] NFS: Use local caching [try #2]

2008-01-23 Thread David Howells
The attached patch makes it possible for the NFS filesystem to make use of the network filesystem local caching service (FS-Cache). To be able to use this, an updated mount program is required. This can be obtained from: http://people.redhat.com/steved/fscache/util-linux/ To mount an NF

[PATCH 24/27] NFS: Use local caching

2008-01-22 Thread David Howells
The attached patch makes it possible for the NFS filesystem to make use of the network filesystem local caching service (FS-Cache). To be able to use this, an updated mount program is required. This can be obtained from: http://people.redhat.com/steved/fscache/util-linux/ To mount an NF