Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > Indeed, as the EBDA_ADDR_POINTER is not aligned, this may work even > better. > > It seems to me safe to assume that if we read zero on that line: > > ebda_addr = *(unsigned short *)__va(EBDA_ADDR_POINTER); > > We could just do ebda_size = 0 and go home happy, ski

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Glauber de Oliveira Costa
Jeremy Fitzhardinge escreveu: Glauber de Oliveira Costa wrote: I think the idea you gave me earlier of using probe_kernel_address could work. Xen/lguest/put_yours_here that won't use an ebda would then have to unmap the page, to make sure a read would fault. Hm, the memory might be mapped anyw

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > I think the idea you gave me earlier of using probe_kernel_address could > work. Xen/lguest/put_yours_here that won't use an ebda would then have > to unmap the page, to make sure a read would fault. Hm, the memory might be mapped anyway, but we could make sure i

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Glauber de Oliveira Costa
Jeremy Fitzhardinge escreveu: Glauber de Oliveira Costa wrote: On 8/9/07, Alan Cox <[EMAIL PROTECTED]> wrote: What's the EBDA actually used for? The only place which seems to use ebda_addr is in the e820 code to avoid that area as RAM. It belongs to the firmware. Wouldn't it b

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > On 8/9/07, Alan Cox <[EMAIL PROTECTED]> wrote: > >>> What's the EBDA actually used for? The only place which seems to use >>> ebda_addr is in the e820 code to avoid that area as RAM. >>> >> It belongs to the firmware. >> > > Wouldn't it be better,

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Alan Cox
On Fri, 10 Aug 2007 15:08:35 -0300 "Glauber de Oliveira Costa" <[EMAIL PROTECTED]> wrote: > On 8/9/07, Alan Cox <[EMAIL PROTECTED]> wrote: > > > What's the EBDA actually used for? The only place which seems to use > > > ebda_addr is in the e820 code to avoid that area as RAM. > > > > It belongs t

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Glauber de Oliveira Costa
On 8/9/07, Alan Cox <[EMAIL PROTECTED]> wrote: > > What's the EBDA actually used for? The only place which seems to use > > ebda_addr is in the e820 code to avoid that area as RAM. > > It belongs to the firmware. Wouldn't it be better, then, to just skip this step unconditionally if we are runnin

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-09 Thread Alan Cox
> What's the EBDA actually used for? The only place which seems to use > ebda_addr is in the e820 code to avoid that area as RAM. It belongs to the firmware. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-09 Thread Jeremy Fitzhardinge
Andi Kleen wrote: >> -static void discover_ebda(void) >> +void native_ebda_info(unsigned *addr, unsigned *size) >> > > I guess it would be better to use the resources frame work here. > Before checking EBDA check if it is already reserved. Then lguest/Xen > can reserve these areas and stop us

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-08 Thread Andi Kleen
On Wednesday 08 August 2007 16:08:25 Glauber de Oliveira Costa wrote: > On 8/8/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > -static void discover_ebda(void) > > > +void native_ebda_info(unsigned *addr, unsigned *size) > > > > I guess it would be better to use the resources frame work here. >

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-08 Thread Glauber de Oliveira Costa
On 8/8/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > > > -static void discover_ebda(void) > > +void native_ebda_info(unsigned *addr, unsigned *size) > > I guess it would be better to use the resources frame work here. > Before checking EBDA check if it is already reserved. Then lguest/Xen > can reser

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-08 Thread Andi Kleen
> -static void discover_ebda(void) > +void native_ebda_info(unsigned *addr, unsigned *size) I guess it would be better to use the resources frame work here. Before checking EBDA check if it is already reserved. Then lguest/Xen can reserve these areas and stop using it. > +/* Overridden in para

[PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-08 Thread Glauber de Oliveira Costa
This patch add paravirtualization hooks in the arch initialization process. paravirt_arch_setup() lets the guest issue any specific initialization routine, and skip all the rest if it see fits, which it signals by a proper return value. In case the initialization continues, we hook at least memory