Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-27 Thread Jiri Olsa
On Thu, Nov 26, 2020 at 02:57:06PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 26, 2020 at 06:00:23PM +0100, Jiri Olsa escreveu: > > Adding support to specify perf data file as -a option file > > argument, > > > > If the file is detected to be perf data file, it is processed > > and all d

Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 26, 2020 at 06:00:23PM +0100, Jiri Olsa escreveu: > Adding support to specify perf data file as -a option file > argument, > > If the file is detected to be perf data file, it is processed > and all dso objects with sample hit are stored to the build > id cache. Would be interesting i

[PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-26 Thread Jiri Olsa
Adding support to specify perf data file as -a option file argument, If the file is detected to be perf data file, it is processed and all dso objects with sample hit are stored to the build id cache. $ DEBUGINFOD_URLS=http://192.168.122.174:8002 perf buildid-cache -a perf.data OK 5dcec522a

Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-25 Thread Namhyung Kim
On Thu, Nov 26, 2020 at 1:36 AM Jiri Olsa wrote: > > On Wed, Nov 25, 2020 at 10:00:10PM +0900, Namhyung Kim wrote: > > On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa wrote: > > > > > > Adding support to specify perf data file as -a option file > > > argument, > > > > > > If the file is detected to be

Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-25 Thread Jiri Olsa
On Wed, Nov 25, 2020 at 10:00:10PM +0900, Namhyung Kim wrote: > On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa wrote: > > > > Adding support to specify perf data file as -a option file > > argument, > > > > If the file is detected to be perf data file, it is processed > > and all dso objects with sampl

Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-25 Thread Jiri Olsa
On Wed, Nov 25, 2020 at 10:29:11PM +0900, Namhyung Kim wrote: SNIP > > +#ifdef HAVE_DEBUGINFOD_SUPPORT > > +static int call_debuginfod(const char *sbuild_id, char **path, bool > > debuginfo) > > +{ > > + debuginfod_client *c; > > + int fd; > > + > > + c = debuginfod_begin(); >

Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-25 Thread Namhyung Kim
On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa wrote: > > Adding support to specify perf data file as -a option file > argument, > > If the file is detected to be perf data file, it is processed > and all dso objects with sample hit are stored to the build > id cache. > > $ DEBUGINFOD_URLS=http://192

Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-25 Thread Namhyung Kim
On Wed, Nov 25, 2020 at 10:00 PM Namhyung Kim wrote: > > On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa wrote: > > diff --git a/tools/perf/builtin-buildid-cache.c > > b/tools/perf/builtin-buildid-cache.c > > index a25411926e48..0bfb54ee1e5e 100644 > > --- a/tools/perf/builtin-buildid-cache.c > > +++

Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-25 Thread Namhyung Kim
On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa wrote: > > Adding support to specify perf data file as -a option file > argument, > > If the file is detected to be perf data file, it is processed > and all dso objects with sample hit are stored to the build > id cache. > > $ DEBUGINFOD_URLS=http://192

[PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

2020-11-23 Thread Jiri Olsa
Adding support to specify perf data file as -a option file argument, If the file is detected to be perf data file, it is processed and all dso objects with sample hit are stored to the build id cache. $ DEBUGINFOD_URLS=http://192.168.122.174:8002 perf buildid-cache -a perf.data OK 5dcec522a