Re: [PATCH 21/77] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Tejun Heo
Hello, On Wed, Feb 6, 2013 at 2:32 PM, Andrew Morton wrote: >> Can you please drop 21 and 22? Everything else shouldn't be affected >> and we can sort these out later. The actual deprecation patch is held >> off for now anyway. > > hm, I could. Instead I merged your patch on top of Tomas's and

Re: [PATCH 21/77] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Andrew Morton
On Wed, 6 Feb 2013 14:27:55 -0800 Tejun Heo wrote: > Hello, Andrew. > > On Wed, Feb 06, 2013 at 02:24:22PM -0800, Andrew Morton wrote: > > This gets all tangled up with > > http://ozlabs.org/~akpm/mmotm/broken-out/block-fix-ext_devt_idr-handling.patch, > > which appears to solve the same issue.

Re: [PATCH 21/77] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Tejun Heo
Hello, Andrew. On Wed, Feb 06, 2013 at 02:24:22PM -0800, Andrew Morton wrote: > This gets all tangled up with > http://ozlabs.org/~akpm/mmotm/broken-out/block-fix-ext_devt_idr-handling.patch, > which appears to solve the same issue. > > What to do? Can you please drop 21 and 22? Everything else

Re: [PATCH 21/77] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Andrew Morton
On Wed, 6 Feb 2013 11:39:53 -0800 Tejun Heo wrote: > idr allocation in blk_alloc_devt() wasn't synchronized against lookup > and removal, and its limit check was off by one - 1 << MINORBITS is > the number of minors allowed, not the maximum allowed minor. > > Add locking and rename MAX_EXT_DEVT

[PATCH 21/77] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Tejun Heo
idr allocation in blk_alloc_devt() wasn't synchronized against lookup and removal, and its limit check was off by one - 1 << MINORBITS is the number of minors allowed, not the maximum allowed minor. Add locking and rename MAX_EXT_DEVT to NR_EXT_DEVT and fix limit checking. Signed-off-by: Tejun He