Re: [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 07:48:41AM +0800, Yi Yang wrote: > When one cpu is set to offline, the caller process will hang, according to > the trace data, the problem lies in the refcount error in cpufreq driver, > cpufreq_cpu_callback will wait for completion policy->kobj_unregister > which is nerver

Re: [linux-pm] [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 10:52:51AM -0500, Alan Stern wrote: > On Fri, 15 Feb 2008, Yi Yang wrote: > > > This patch adds kobject_put to balance refcount. I noticed Greg suggests > > it will fix a power-off issue to remove kobject_get statement block, but i > > think that isn't the best way because

Re: [linux-pm] [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Alan Stern
On Fri, 15 Feb 2008, Yi Yang wrote: > This patch adds kobject_put to balance refcount. I noticed Greg suggests > it will fix a power-off issue to remove kobject_get statement block, but i > think that isn't the best way because those code block has existed very long > and it is helpful because the

[PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Yi Yang
When one cpu is set to offline, the caller process will hang, according to the trace data, the problem lies in the refcount error in cpufreq driver, cpufreq_cpu_callback will wait for completion policy->kobj_unregister which is nerver completed because a refcount error in function __cpufreq_remove_

[PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Yi Yang
When one cpu is set to offline, the caller process will hang, according to the trace data, the problem lies in the refcount error in cpufreq driver, cpufreq_cpu_callback will wait for completion policy->kobj_unregister which is nerver completed because a refcount error in function __cpufreq_remove_