I'd like to create another thread in LKML for the updated version, sorry.
On Dec 15, 2007 11:56 AM, eric miao <[EMAIL PROTECTED]> wrote:
> OK,
>
> Here's the updated version, which
> 1. modify the author info but still preserve Ben's credit in the source head
> 2. Alphabetic order in Kconfig/Makef
OK,
Here's the updated version, which
1. modify the author info but still preserve Ben's credit in the source head
2. Alphabetic order in Kconfig/Makefile
3. typo fix and corrected Philips to NXP/TI
4. use dev_err instead of printk
5. move module_{init,exit} next to the routines
6. preserve initia
Hi,
> -Original Message-
> > > +MODULE_AUTHOR("Ben Gardner <[EMAIL PROTECTED]>");
> >
> > But not you?
>
> I'm not even sure if Ben can be said to be an author of this new
> driver, as there is almost no common code between the old driver and
> the new one.
I agree with Jean here.
Pleas
Hi David,
On Tue, 11 Dec 2007 20:29:49 -0800, David Brownell wrote:
> > +static int __devinit pca9539_probe(struct i2c_client *client)
> > +{
> > + ...
> > + /* initialize registers */
> > + chip->reg_output = 0x;
> > + chip->reg_direction = 0x;
> > +
> > + pca9539_write_reg(chip
[ do we need so much crossposting on these patches? ]
On Monday 10 December 2007, eric miao wrote:
> + Copyright (C) 2007 Marvell Internation Ltd.
"International"?
> +static int __devinit pca9539_probe(struct i2c_client *client)
> +{
> + ...
> + /* initialize registers */
> + ch
1. use 16-bit register access to simplify the logic, cache OUTPUT
and DIRECTION registers for fast access
2. platform code is required to setup
a) the numbering of GPIO for PCA9539 (base and number)
c) pass "pca9539_platform_data" within "i2c_board_info"
Signed-off-by: eric miao <[EMAIL
6 matches
Mail list logo
