Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-15 Thread Ahmed S. Darwish
On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote: > On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote: > > Substitue intel_rng magic PCI IDs values used in the IDs table > > with the macros defined in pci_ids.h > > Why not use the PCI_DEVICE() macro too? It should make the li

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-15 Thread Ahmed S. Darwish
On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote: > Why not use the PCI_DEVICE() macro too? It should make the lines even > smaller. Hi all, Here's the updated patch. Substitue magic values used in the PCI IDs table with macros defined in pci_ids.h + using the PCI_DEVICE macro. Signed-o

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-15 Thread Ahmed S. Darwish
On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote: > On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote: > > Substitue intel_rng magic PCI IDs values used in the IDs table > > with the macros defined in pci_ids.h > > Why not use the PCI_DEVICE() macro too? It should make the l

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Ahmed S. Darwish
On Sun, Jan 14, 2007 at 09:37:21AM -0800, Arjan van de Ven wrote: > On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > > Substitue intel_rng magic PCI IDs values used in the IDs table > > with the macros defined in pci_ids.h > > > Hi, > > > hmm this is actually the opposite direction t

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Greg KH
On Mon, Jan 15, 2007 at 01:07:18AM +0200, Ahmed S. Darwish wrote: > On Mon, Jan 15, 2007 at 06:31:01AM +1100, Dave Airlie wrote: > > On 1/15/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > >On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > > >> Substitue intel_rng magic PCI IDs value

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Greg KH
On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote: > Substitue intel_rng magic PCI IDs values used in the IDs table > with the macros defined in pci_ids.h Why not use the PCI_DEVICE() macro too? It should make the lines even smaller. thanks, greg k-h - To unsubscribe from this li

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Ahmed S. Darwish
On Mon, Jan 15, 2007 at 06:31:01AM +1100, Dave Airlie wrote: > On 1/15/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > >On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > >> Substitue intel_rng magic PCI IDs values used in the IDs table > >> with the macros defined in pci_ids.h > >> > >

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Dave Airlie
On 1/15/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote: On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > Substitue intel_rng magic PCI IDs values used in the IDs table > with the macros defined in pci_ids.h > Hi, hmm this is actually the opposite direction than most of the kernel is

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Arjan van de Ven
On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > Substitue intel_rng magic PCI IDs values used in the IDs table > with the macros defined in pci_ids.h > Hi, hmm this is actually the opposite direction than most of the kernel is heading in, mostly because the pci_ids.h file is a major

[PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Ahmed S. Darwish
Substitue intel_rng magic PCI IDs values used in the IDs table with the macros defined in pci_ids.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- I've used a small script to generate this patch then manually tried to make sure it's (hopefully) correct. #!/bin/bash INTEL_RNG_FILE=dr