Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-13 Thread Alan
> >>+static int tc86c001_busproc(ide_drive_t *drive, int state) > >>+{ > > > Waste of space having a busproc routine. The maintainer removed all the > > usable hotplug support from old IDE so this might as well be dropped. > > Don't know what you mean, ioctl is still there... You can turn th

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-13 Thread Sergei Shtylyov
Hello. Alan wrote: + * We work around this by initiating dummy, zero-length DMA transfer on + * a DMA timeout expiration. I found no better way to do this with the current Novel workaround and probably better than resetting the chip as the winbong does. I didn't try resetting however th

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-13 Thread Bartlomiej Zolnierkiewicz
On 12/13/06, Alan <[EMAIL PROTECTED]> wrote: > Unfortunately it seems that not everybody has moved on. It is not > about your not accepted patches but about "the maintainer removed > all the usable hotplug support from old IDE" false accusations which > are unproven and untrue. Moreover I coul

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-13 Thread Alan
> Unfortunately it seems that not everybody has moved on. It is not > about your not accepted patches but about "the maintainer removed > all the usable hotplug support from old IDE" false accusations which > are unproven and untrue. I invite anyone who cares to study the archive. Welcome back t

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-13 Thread Bartlomiej Zolnierkiewicz
On 12/13/06, Alan <[EMAIL PROTECTED]> wrote: > > Waste of space having a busproc routine. The maintainer removed all the > > usable hotplug support from old IDE so this might as well be dropped. > > I took over IDE when hotplug was already broken (late 2.5), moreover IDE > hotplug support has bee

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-13 Thread Alan
> > Waste of space having a busproc routine. The maintainer removed all the > > usable hotplug support from old IDE so this might as well be dropped. > > I took over IDE when hotplug was already broken (late 2.5), moreover IDE > hotplug support has been always a quick hack according to its origina

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Bartlomiej Zolnierkiewicz
On 12/13/06, Alan <[EMAIL PROTECTED]> wrote: > +static int tc86c001_busproc(ide_drive_t *drive, int state) > +{ Waste of space having a busproc routine. The maintainer removed all the usable hotplug support from old IDE so this might as well be dropped. I took over IDE when hotplug was alread

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Alan
On Wed, 13 Dec 2006 01:48:34 +0300 Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, > completely reworked from the original brain-damaged Toshiba's 2.4 version. Actually un-nack the PCI quirk. While it is true the native mode

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Alan
> + * We work around this by initiating dummy, zero-length DMA transfer on > + * a DMA timeout expiration. I found no better way to do this with the > current Novel workaround and probably better than resetting the chip as the winbong does. > +static int tc86c001_busproc(ide_drive_t *drive, int

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Randy Dunlap
Sergei Shtylyov wrote: Hello. Randy Dunlap wrote: Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, completely reworked from the original brain-damaged Toshiba's 2.4 version. This single channel UltraDMA/66 controller is very simple in programming, yet Toshiba man

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Sergei Shtylyov
Hello. Randy Dunlap wrote: Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, completely reworked from the original brain-damaged Toshiba's 2.4 version. This single channel UltraDMA/66 controller is very simple in programming, yet Toshiba managed to plant many interest

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Randy Dunlap
On Wed, 13 Dec 2006 01:48:34 +0300 Sergei Shtylyov wrote: > Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, > completely reworked from the original brain-damaged Toshiba's 2.4 version. > > This single channel UltraDMA/66 controller is very simple in programming, yet >

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Sergei Shtylyov
Hello. On Wednesday 13 December 2006 01:48, Sergei Shtylyov wrote: > Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, > completely reworked from the original brain-damaged Toshiba's 2.4 version. Shoot, the patch is actually against the most recent Linus' tree, so it'

[PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Sergei Shtylyov
Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, completely reworked from the original brain-damaged Toshiba's 2.4 version. This single channel UltraDMA/66 controller is very simple in programming, yet Toshiba managed to plant many interesting bugs in it. The particular