Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-07 Thread Jay Lan
The patch i propose is tiny, simple and straight forward. It touches only one file and leaves the CSA code in a configurable loadable module. It broke nobody's code and it does not need to redesign existing BSD kernel code and utilities. If we are to merge the code, there are some detailed discuss

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-04 Thread Tim Schmielau
On Wed, 2 Mar 2005, Guillaume Thouvenin wrote: > Is it possible to merge BSD and CSA? I mean with CSA, there is a part > that does per-process accounting. For exemple in the > linux-2.6.9.acct_mm.patch the two functions update_mem_hiwater() and > csa_update_integrals() update fields in the current

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-02 Thread Jay Lan
I did not look into the userspace commands supported in BSD accounting on the dependency on the format of /var/account/pacct file. The accounting exit hook allows BSD/CSA to save accounting data stored in task_struct to internally kept data structure and then writes to their respective accounting f

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-02 Thread Jesse Barnes
On Tuesday, March 1, 2005 11:48 pm, Guillaume Thouvenin wrote: > Is it possible to merge BSD and CSA? I mean with CSA, there is a part > that does per-process accounting. For exemple in the > linux-2.6.9.acct_mm.patch the two functions update_mem_hiwater() and > csa_update_integrals() update fields

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-01 Thread Guillaume Thouvenin
On Tue, 2005-03-01 at 10:06 -0800, Jay Lan wrote: > Sorry I was not clear on my point. > > I was trying to point out that, an exit hook for BSD and CSA is > essential to save accounting data before the data is gone. That > can not be done with a netlink. > > So, my patch was to keep acct_process

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-01 Thread Jay Lan
Sorry I was not clear on my point. I was trying to point out that, an exit hook for BSD and CSA is essential to save accounting data before the data is gone. That can not be done with a netlink. So, my patch was to keep acct_process as a wrapper, which would then call do_exit_csa() for CSA and call

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-28 Thread Guillaume Thouvenin
On Mon, 2005-02-28 at 10:56 -0800, Jay Lan wrote: > The exit hook is essential for CSA to save off data before the data > is gone, A netlink type of thing does not help. BSD is in the same > situation. You can not replace the acct_process() call with a netlink. > If ELSA is to use the enhanced acco

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-28 Thread Jay Lan
Hi Andrew, You asked: > > In other words: given that ELSA can do its thing via existing accounting > interfaces and a fork notifier, why does CSA need to add lots more kernel > code? And i explained: > Here are some codes from do_exit() starting line 813 (based on > 2.6.11-rc4-mm1): > > 813

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-24 Thread Guillaume Thouvenin
On Thu, 2005-02-24 at 20:46 -0800, Andrew Morton wrote: > Jay Lan <[EMAIL PROTECTED]> wrote: > > > > Since my idea of providing an accounting framework was considered > > 'overkill', here i submit a tiny patch just to allow CSA to > > handle end-of-process (eop) situation by saving off accounting

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-24 Thread Andrew Morton
Jay Lan <[EMAIL PROTECTED]> wrote: > > Since my idea of providing an accounting framework was considered > 'overkill', here i submit a tiny patch just to allow CSA to > handle end-of-process (eop) situation by saving off accounting > data before a task_struct is disposed. > > This patch is to

[PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-24 Thread Jay Lan
Since my idea of providing an accounting framework was considered 'overkill', here i submit a tiny patch just to allow CSA to handle end-of-process (eop) situation by saving off accounting data before a task_struct is disposed. This patch is to modify the acct_process() in acct.c, which is invoked