Re: [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-27 Thread Bill Davidsen
Andreas Gruenbacher wrote: On Wed, 2005-01-26 at 15:09, Matt Domsch wrote: On Wed, Jan 26, 2005 at 10:22:29AM +0100, Andreas Gruenbacher wrote: On Wednesday 26 January 2005 07:05, Matt Domsch wrote: Module: Add module version and srcversion to the sysfs tree why do you need this? a) Tools like DKM

Re: [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-27 Thread Matt Domsch
On Wed, Jan 26, 2005 at 05:38:51PM +0100, Andreas Gruenbacher wrote: > > The autoinstaller feature, > > for example, which determines if your system has a "good" version of a > > driver (i.e. if the one provided by DKMS has a newer verson than that > > provided by the kernel package installed), and

Re: [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-26 Thread Rusty Russell
On Wed, 2005-01-26 at 14:32 +, Paulo Marques wrote: > Matt Domsch wrote: > > [...] > > > > +static char *strdup(const char *str) ... > Actually, I've just grep'ed the entire tree and there are about 7 > similar implementations all over the place: Wow, I'd never noticed. Linus, please apply

Re: [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-26 Thread Andreas Gruenbacher
On Wed, 2005-01-26 at 15:09, Matt Domsch wrote: > On Wed, Jan 26, 2005 at 10:22:29AM +0100, Andreas Gruenbacher wrote: > > On Wednesday 26 January 2005 07:05, Matt Domsch wrote: > > > Module: Add module version and srcversion to the sysfs tree > > > > why do you need this? > > a) Tools like DKMS

Re: [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-26 Thread Paulo Marques
Matt Domsch wrote: [...] +static char *strdup(const char *str) +{ + char *s; + + if (!str) + return NULL; + s = kmalloc(strlen(str)+1, GFP_KERNEL); + if (!s) + return NULL; + strcpy(s, str); + return s; +} + There is already this code in sound/core/memory.c: char *snd_kmalloc_strdup(const char

Re: [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-26 Thread Matt Domsch
On Wed, Jan 26, 2005 at 10:22:29AM +0100, Andreas Gruenbacher wrote: > On Wednesday 26 January 2005 07:05, Matt Domsch wrote: > > Module: Add module version and srcversion to the sysfs tree > > why do you need this? a) Tools like DKMS, which deal with changing out individual kernel modules witho

Re: [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-26 Thread Andreas Gruenbacher
Hello, On Wednesday 26 January 2005 07:05, Matt Domsch wrote: > Module: Add module version and srcversion to the sysfs tree why do you need this? Thanks, -- Andreas Gruenbacher <[EMAIL PROTECTED]> SUSE Labs, SUSE LINUX PRODUCTS GMBH - To unsubscribe from this list: send the line "unsubscribe l

[PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs

2005-01-25 Thread Matt Domsch
Module: Add module version and srcversion to the sysfs tree There are two ways one could go with this: 1) strdup() the interesting fields from modinfo section before it is discarded. That's what this patch does, and what Greg's original patch did too, despite his reservations about using strdup()