Re: [PATCH 2.6] (10/11) hwmon vs i2c, second round

2005-07-31 Thread Jean Delvare
Hi Alexey, > > I see very little reason why vid_from_reg and vid_to_reg are > > inlined. The former is not exactly short, > > 1) > and their arguments aren't known at > compile time, > > [Compiler can optimise them away _completely_ if both arguments are > known

Re: [PATCH 2.6] (10/11) hwmon vs i2c, second round

2005-07-31 Thread Alexey Dobriyan
One nitpicking comment and two observations: On Sun, Jul 31, 2005 at 10:02:24PM +0200, Jean Delvare wrote: > I see very little reason why vid_from_reg and vid_to_reg are inlined. > The former is not exactly short, 1) and their arguments aren't known at compile t

[PATCH 2.6] (10/11) hwmon vs i2c, second round

2005-07-31 Thread Jean Delvare
I see very little reason why vid_from_reg and vid_to_reg are inlined. The former is not exactly short, and they are never called in speed critical areas. Uninlining them should cause little performance loss if any, and saves a signficant space and compilation time as well. Signed-off-by: Jean Delv