Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-09-25 Thread Mark Brown
On Wed, Sep 06, 2017 at 06:45:22PM -0700, Lori Hikichi wrote: > This will likely impact a couple of the other patches in the series, but > most should be applicable. What would be the best way to have some of the > other patches in this series reviewed? Should I just drop this series and > resubm

Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-09-06 Thread Lori Hikichi
On 8/22/2017 9:07 AM, Mark Brown wrote: > On Wed, Aug 16, 2017 at 12:39:42PM -0700, Lori Hikichi wrote: > >> By far the most common usage case for Cygnus is a configuration which >> uses only the three i2s/tdm ports. In this case each port is assigned >> a clock. Each clock has the same capabili

Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-08-22 Thread Mark Brown
On Wed, Aug 16, 2017 at 12:39:42PM -0700, Lori Hikichi wrote: > By far the most common usage case for Cygnus is a configuration which > uses only the three i2s/tdm ports. In this case each port is assigned > a clock. Each clock has the same capabilities so there would never be > a reason change t

Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-08-16 Thread Lori Hikichi
On 8/16/2017 3:59 AM, Mark Brown wrote: > On Tue, Aug 15, 2017 at 12:29:44PM -0700, Lori Hikichi wrote: > >> I have put the mux assignment in DT because the assignment is a >> static property and did not need run time programmability from the >> machine driver. > Why is this a static property, wha

Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-08-16 Thread Mark Brown
On Tue, Aug 15, 2017 at 12:29:44PM -0700, Lori Hikichi wrote: > I have put the mux assignment in DT because the assignment is a > static property and did not need run time programmability from the > machine driver. Why is this a static property, what prevents something wanting to change things at

Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-08-15 Thread Lori Hikichi
On 8/15/2017 10:14 AM, Mark Brown wrote: > On Mon, Aug 14, 2017 at 03:06:50PM -0700, Lori Hikichi wrote: >> Allow each audio port to select which clock (if any) it wants to use. > Why is this in DT for the port and not either using standard clock > bindings to configure the clock tree or allowing

Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-08-15 Thread Mark Brown
On Mon, Aug 14, 2017 at 03:06:50PM -0700, Lori Hikichi wrote: > Allow each audio port to select which clock (if any) it wants to use. Why is this in DT for the port and not either using standard clock bindings to configure the clock tree or allowing the machine driver to pick? signature.asc Desc

[PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-08-14 Thread Lori Hikichi
Allow each audio port to select which clock (if any) it wants to use. Signed-off-by: Lori Hikichi --- .../bindings/sound/brcm,cygnus-audio.txt | 70 ++ 1 file changed, 45 insertions(+), 25 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/brcm,cygnu