Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread John Hubbard
On 9/29/20 1:20 PM, Shuah Khan wrote: On 9/29/20 2:11 PM, John Hubbard wrote: ... Do you have a link or two for that? Especially about the pushback, and conclusions reached, if any. Unfortunately no. A I recall it was workflow related issues and ease of running individual subsystem tests and

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread Shuah Khan
On 9/29/20 2:11 PM, John Hubbard wrote: On 9/29/20 1:00 PM, Shuah Khan wrote: On 9/29/20 1:53 PM, Jason Gunthorpe wrote: I only remarked because I didn't know it wasn't using kbuild. I thought it would have used the existing HOSTCC stuff, not sure why it is special. The only investment that se

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread John Hubbard
On 9/29/20 1:00 PM, Shuah Khan wrote: On 9/29/20 1:53 PM, Jason Gunthorpe wrote: I only remarked because I didn't know it wasn't using kbuild. I thought it would have used the existing HOSTCC stuff, not sure why it is special. The only investment that seems worthwhile would be to switch it to u

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread Shuah Khan
On 9/29/20 1:53 PM, Jason Gunthorpe wrote: On Tue, Sep 29, 2020 at 12:48:43PM -0700, John Hubbard wrote: On 9/29/20 12:08 PM, Jason Gunthorpe wrote: On Tue, Sep 29, 2020 at 11:59:55AM -0700, John Hubbard wrote: On 9/29/20 10:55 AM, Jason Gunthorpe wrote: On Tue, Sep 29, 2020 at 10:44:31AM -07

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread Jason Gunthorpe
On Tue, Sep 29, 2020 at 12:48:43PM -0700, John Hubbard wrote: > On 9/29/20 12:08 PM, Jason Gunthorpe wrote: > > On Tue, Sep 29, 2020 at 11:59:55AM -0700, John Hubbard wrote: > > > On 9/29/20 10:55 AM, Jason Gunthorpe wrote: > > > > On Tue, Sep 29, 2020 at 10:44:31AM -0700, John Hubbard wrote: > > >

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread John Hubbard
On 9/29/20 12:08 PM, Jason Gunthorpe wrote: On Tue, Sep 29, 2020 at 11:59:55AM -0700, John Hubbard wrote: On 9/29/20 10:55 AM, Jason Gunthorpe wrote: On Tue, Sep 29, 2020 at 10:44:31AM -0700, John Hubbard wrote: On 9/29/20 9:35 AM, Jason Gunthorpe wrote: On Mon, Sep 28, 2020 at 01:10:24PM -07

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread Jason Gunthorpe
On Tue, Sep 29, 2020 at 11:59:55AM -0700, John Hubbard wrote: > On 9/29/20 10:55 AM, Jason Gunthorpe wrote: > > On Tue, Sep 29, 2020 at 10:44:31AM -0700, John Hubbard wrote: > > > On 9/29/20 9:35 AM, Jason Gunthorpe wrote: > > > > On Mon, Sep 28, 2020 at 01:10:24PM -0700, John Hubbard wrote: > > >

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread John Hubbard
On 9/29/20 10:55 AM, Jason Gunthorpe wrote: On Tue, Sep 29, 2020 at 10:44:31AM -0700, John Hubbard wrote: On 9/29/20 9:35 AM, Jason Gunthorpe wrote: On Mon, Sep 28, 2020 at 01:10:24PM -0700, John Hubbard wrote: On 9/28/20 5:57 AM, Jason Gunthorpe wrote: On Sun, Sep 27, 2020 at 11:21:53PM -070

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread Jason Gunthorpe
On Tue, Sep 29, 2020 at 10:44:31AM -0700, John Hubbard wrote: > On 9/29/20 9:35 AM, Jason Gunthorpe wrote: > > On Mon, Sep 28, 2020 at 01:10:24PM -0700, John Hubbard wrote: > > > On 9/28/20 5:57 AM, Jason Gunthorpe wrote: > > > > On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: > > > >

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread John Hubbard
On 9/29/20 9:35 AM, Jason Gunthorpe wrote: On Mon, Sep 28, 2020 at 01:10:24PM -0700, John Hubbard wrote: On 9/28/20 5:57 AM, Jason Gunthorpe wrote: On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makef

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-29 Thread Jason Gunthorpe
On Mon, Sep 28, 2020 at 01:10:24PM -0700, John Hubbard wrote: > On 9/28/20 5:57 AM, Jason Gunthorpe wrote: > > On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: > > > diff --git a/tools/testing/selftests/vm/Makefile > > > b/tools/testing/selftests/vm/Makefile > > > index d1ae706d9927..

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-28 Thread John Hubbard
On 9/28/20 5:57 AM, Jason Gunthorpe wrote: On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index d1ae706d9927..9cc6bc087461 100644 +++ b/tools/testing/selftests/vm/Makefile @@ -130,3 +130,5 @@ e

Re: [PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-28 Thread Jason Gunthorpe
On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: > diff --git a/tools/testing/selftests/vm/Makefile > b/tools/testing/selftests/vm/Makefile > index d1ae706d9927..9cc6bc087461 100644 > +++ b/tools/testing/selftests/vm/Makefile > @@ -130,3 +130,5 @@ endif > $(OUTPUT)/userfaultfd: LDLIB

[PATCH 2/8] selftests/vm: use a common gup_test.h

2020-09-27 Thread John Hubbard
Avoid the need to copy-paste the gup_test ioctl commands and the struct gup_test definition, between the kernel and the user space application, by providing a new header file for these. This allows easier and safer adding of new ioctl calls, as well as reducing the overall line count. Details: The