On 04/16/2014 10:47 AM, Christoph Hellwig wrote:
> On Wed, Apr 16, 2014 at 10:45:03AM -0600, Jens Axboe wrote:
>> There's nothing wrong with the check, it's identical to one I sent out
>> last week. But it's not part of the bidi enable patch, it's a separate
>> bug fix for bsg.
>
> Do you want to
On Wed, Apr 16, 2014 at 10:45:03AM -0600, Jens Axboe wrote:
> There's nothing wrong with the check, it's identical to one I sent out
> last week. But it's not part of the bidi enable patch, it's a separate
> bug fix for bsg.
Do you want to split it up while applying or should I resend two
separate
On 04/16/2014 10:44 AM, Christoph Hellwig wrote:
> On Wed, Apr 16, 2014 at 10:41:30AM -0600, Jens Axboe wrote:
>>> - if (!q->request_fn)
>>> + if (!q->request_fn && !q->mq_ops)
>>> return 0;
>>>
>>> bcd = &q->bsg_dev;
>>
>> This looks misplaced. But I dropped the one I generat
On Wed, Apr 16, 2014 at 10:41:30AM -0600, Jens Axboe wrote:
> > - if (!q->request_fn)
> > + if (!q->request_fn && !q->mq_ops)
> > return 0;
> >
> > bcd = &q->bsg_dev;
>
> This looks misplaced. But I dropped the one I generated last week, I'll
> queue it up separately in the d
On 04/16/2014 01:44 AM, Christoph Hellwig wrote:
> diff --git a/block/bsg.c b/block/bsg.c
> index 420a5a9..2956086 100644
> --- a/block/bsg.c
> +++ b/block/bsg.c
> @@ -1008,7 +1008,7 @@ int bsg_register_queue(struct request_queue *q, struct
> device *parent,
> /*
>* we need a proper
Add two unlinkely branches to make sure the resid is initialized correctly
for bidi request pairs, and the second request gets properly freed.
Signed-off-by: Christoph Hellwig
---
block/blk-mq.c |9 +++--
block/bsg.c|2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --
6 matches
Mail list logo
