Re: [PATCH 2/8] FMC: add needed headers

2013-06-19 Thread Alessandro Rubini
> The use of the 'readl' and 'writel' identifiers here causes build errors on > architectures where those are macros. This renames the fields to > read32/write32 > to avoid the problem. Thanks. I'll apply the same to my repo and related drivers. Acked-by: Alessandro Rubini /alessandro -- To u

Re: [PATCH 2/8] FMC: add needed headers

2013-06-19 Thread Arnd Bergmann
On Wednesday 12 June 2013 09:13:36 Alessandro Rubini wrote: > + */ > +struct fmc_operations { > + uint32_t (*readl)(struct fmc_device *fmc, int offset); > + void (*writel)(struct fmc_device *fmc, uint32_t value, int offset); > + int (*validate)(struct fmc_device *fmc, struct fmc_d

Re: [PATCH 2/8] FMC: add needed headers

2013-06-17 Thread Greg KH
On Tue, Jun 18, 2013 at 01:29:02AM +0200, Alessandro Rubini wrote: > > Any way you can use MODULE_DEVICE_TABLE() for these devices to get > > proper module auto-loading for your drivers? > > It's the next step. Ok, good. > We are not doing that in our installations because it is not a trivial >

Re: [PATCH 2/8] FMC: add needed headers

2013-06-17 Thread Alessandro Rubini
> Any way you can use MODULE_DEVICE_TABLE() for these devices to get > proper module auto-loading for your drivers? It's the next step. We are not doing that in our installations because it is not a trivial addition to running kernels -- we are plugging FMC devices in already-deployed kernel vers

Re: [PATCH 2/8] FMC: add needed headers

2013-06-17 Thread Greg KH
On Wed, Jun 12, 2013 at 09:13:36AM +0200, Alessandro Rubini wrote: > +/* > + * The device reports all information needed to access hw. > + * > + * If we have eeprom_len and not contents, the core reads it. > + * Then, parsing of identifiers is done by the core which fills fmc_fru_id.. > + * Similar

[PATCH 2/8] FMC: add needed headers

2013-06-12 Thread Alessandro Rubini
This set of headers comes from commit ab23167f (current master of the project on ohwr.org). They define the basic data structures for FMC and its SDB support. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez ---

[PATCH 2/8] FMC: add needed headers

2013-02-21 Thread Alessandro Rubini
This set of headers comes from commit 55812ecd (current master of the project on ohwr.org). They define the basic data structures for FMC and its SDB support. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez ---