Re: [PATCH 2/7] sfc: drop unnecessary list_empty

2020-07-27 Thread David Miller
From: Julia Lawall Date: Sun, 26 Jul 2020 12:58:27 +0200 > list_for_each_safe is able to handle an empty list. > The only effect of avoiding the loop is not initializing the > index variable. > Drop list_empty tests in cases where these variables are not > used. > > The semantic patch that makes

Re: [PATCH 2/7] sfc: drop unnecessary list_empty

2020-07-27 Thread Edward Cree
On 26/07/2020 11:58, Julia Lawall wrote: > list_for_each_safe is able to handle an empty list. > The only effect of avoiding the loop is not initializing the > index variable. > Drop list_empty tests in cases where these variables are not > used. Sure, why not. Acked-by: Edward Cree

[PATCH 2/7] sfc: drop unnecessary list_empty

2020-07-26 Thread Julia Lawall
list_for_each_safe is able to handle an empty list. The only effect of avoiding the loop is not initializing the index variable. Drop list_empty tests in cases where these variables are not used. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) @@ expression