Re: [PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs

2017-05-31 Thread Christoph Hellwig
On Tue, May 30, 2017 at 11:48:09AM +0200, Johannes Thumshirn wrote: > On 05/30/2017 11:24 AM, Christoph Hellwig wrote: > > This should be stored as a uuid_t (or rather uuid_be in the current > > kernel, but I'm about to rename it), and use uuid_be_to_bin / uuid_to_bin > > for parsing. > > OK, thou

Re: [PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs

2017-05-30 Thread Johannes Thumshirn
On 05/30/2017 11:24 AM, Christoph Hellwig wrote: > This should be stored as a uuid_t (or rather uuid_be in the current > kernel, but I'm about to rename it), and use uuid_be_to_bin / uuid_to_bin > for parsing. OK, thought you ask me to do that. Which one do you prefer? -- Johannes Thumshirn

Re: [PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs

2017-05-30 Thread Christoph Hellwig
This should be stored as a uuid_t (or rather uuid_be in the current kernel, but I'm about to rename it), and use uuid_be_to_bin / uuid_to_bin for parsing.

Re: [PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs

2017-05-30 Thread Hannes Reinecke
On 05/30/2017 10:08 AM, Johannes Thumshirn wrote: > Add the UUID field from the NVMe Namespace Identification Descriptor > to the nvmet_ns structure and allow it's population via configfs. > > Signed-off-by: Johannes Thumshirn > --- > drivers/nvme/target/configfs.c | 48 > ++

[PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs

2017-05-30 Thread Johannes Thumshirn
Add the UUID field from the NVMe Namespace Identification Descriptor to the nvmet_ns structure and allow it's population via configfs. Signed-off-by: Johannes Thumshirn --- drivers/nvme/target/configfs.c | 48 ++ drivers/nvme/target/nvmet.h| 1 + 2 fi