Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-16 Thread Stefan Richter
Dave Young wrote: > Convert to use the class iteration api. I'll try to review and test it at the weekend. Thanks for patiently going through all the patch iterations. -- Stefan Richter -=-==--- ---= =---= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-15 Thread Dave Young
Thanks for stefan's help to finish this patch, now updated one: Convert to use the class iteration api. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/ieee1394/nodemgr.c | 312 + 1 file changed, 175 insertions(+), 137 deletions(-) diff -

Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-15 Thread Stefan Richter
Dave Young wrote: > Is it right for me to put_device after class_find_device at following point? Yes, that's right. -- Stefan Richter -=-==--- ---= - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTEC

Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-15 Thread Dave Young
Is it right for me to put_device after class_find_device at following point? On Jan 12, 2008 5:50 PM, Dave Young <[EMAIL PROTECTED]> wrote: > Convert to use the class iteration api. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > > --- > drivers/ieee1394/nodemgr.c | 319 > ++

Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-13 Thread Dave Young
On Jan 12, 2008 7:10 PM, Stefan Richter <[EMAIL PROTECTED]> wrote: > Dave Young wrote: > > +++ linux.new/drivers/ieee1394/nodemgr.c 2008-01-12 15:20:27.0 > > +0800 > ... > > > static void nodemgr_remove_uds(struct node_entry *ne) > > { > > struct device *dev; > > - struct

Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-12 Thread Stefan Richter
> Dave Young wrote: >> +++ linux.new/drivers/ieee1394/nodemgr.c 2008-01-12 15:20:27.0 >> +0800 > ... >> static void nodemgr_remove_uds(struct node_entry *ne) >> { >> struct device *dev; >> -struct unit_directory *tmp, *ud; >> +struct unit_directory *ud; >> >> -/* I

Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-12 Thread Stefan Richter
Dave Young wrote: > +++ linux.new/drivers/ieee1394/nodemgr.c 2008-01-12 15:20:27.0 > +0800 ... > static void nodemgr_remove_uds(struct node_entry *ne) > { > struct device *dev; > - struct unit_directory *tmp, *ud; > + struct unit_directory *ud; > > - /* Iteration

[PATCH 2/7] ieee1394 : use class iteration api

2008-01-12 Thread Dave Young
Convert to use the class iteration api. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/ieee1394/nodemgr.c | 319 + 1 file changed, 178 insertions(+), 141 deletions(-) diff -upr linux/drivers/ieee1394/nodemgr.c linux.new/drivers/ieee1394/n