Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

2016-07-04 Thread Matt Fleming
On Mon, 27 Jun, at 12:49:20PM, Ingo Molnar wrote: > The other weirdness is the misalignment of the '0xe' portion here: > > #define LINUX_EFI_ARM_SCREEN_INFO_TABLE_GUID EFI_GUID(0xe03fc20a, 0x85dc, > 0x406e, 0xb9, 0xe, 0x4a, 0xb5, 0x02, 0x37, 0x1d, 0x95) > #define LINUX_EFI_LOADER_ENTRY_GUID

Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

2016-06-27 Thread Joe Perches
On Mon, 2016-06-27 at 12:49 +0200, Ingo Molnar wrote: > * Matt Fleming wrote: [] > > + * EFI Configuration Table and GUID definitions > > + * > > + * These should be formatted roughly like the ones in the UEFI SPEC has > > + * them.  It makes them easier to grep for, and they look the same when >

Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

2016-06-27 Thread Ingo Molnar
* Matt Fleming wrote: > From: Peter Jones > > Add a comment documenting why EFI GUIDs are laid out like they are. > Ideally I'd like to change all the ", " to "," too, but right now the > format is such that checkpatch won't complain with new ones, and staring > at checkpatch didn't get me any

[PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

2016-06-25 Thread Matt Fleming
From: Peter Jones Add a comment documenting why EFI GUIDs are laid out like they are. Ideally I'd like to change all the ", " to "," too, but right now the format is such that checkpatch won't complain with new ones, and staring at checkpatch didn't get me anywhere towards making that work. Sign